Re: [PATCH v2 0/2] generic/577: fix hash check and add metadata cleaning

[Eric Biggers <ebiggers@kernel.org>]

On Thu, Nov 03, 2022 at 08:14:18PM +0100, Andrey Albershteyn wrote:
> Hi all,
> 
> This patchset has two fixes for generic/577. The first one is fix of
> common helper _fsv_have_hash_algorithm which didn't work correctly in
> generic/577 as that test requires signing. The second patch fixes issue
> which is uncovered when first patch is applied. The test fails to write to file
> with already enabled verity.
> 
> v1 -> v2:
> - add first patch as proper fix
> 
> Andrey Albershteyn (2):
>   common/verity: disable signature verification on hash alg check
>   generic/577: add missing fsverity metadata cleaning
> 
>  common/verity     | 3 +++
>  tests/generic/577 | 1 +
>  2 files changed, 4 insertions(+)
> 

Thanks Andrey!  One thing that you overlooked is that _fsv_have_hash_algorithm()
needs to restore the previous value of fs.verity.require_signatures, not the
value that existed at the beginning of the test.

Also, I found that some of the newer tests don't work properly on systems where
fs.verity.require_signatures=1.  I'd like to fix that too.

Can you take a look at the patchset
https://lore.kernel.org/fstests/20221104064742.167326-1-ebiggers@kernel.org/T/#u
I just sent out?  It should take care of everything...

- Eric