From: "Darrick J. Wong" <djwong@kernel.org>
To: Leah Rumancik <leah.rumancik@gmail.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] check: use /var/tmp instead of /tmp
Date: Mon, 12 Dec 2022 15:18:49 -0800 [thread overview]
Message-ID: <Y5e22dC9jxg4NnxS@magnolia> (raw)
In-Reply-To: <20221212230646.4022294-1-leah.rumancik@gmail.com>
On Mon, Dec 12, 2022 at 03:06:46PM -0800, Leah Rumancik wrote:
> With the results recorded in /tmp, a crashing test results in a loss
> of all prior test runs. Instead, record results in /var/tmp so that
> it is possible to recover results from completed tests.
RESULT_BASE=/some/stable/storage ./check <args> ?
> Also, make sure tmp.arglist is wiped before each run to avoid
> accidentally rerunning tests.
>
> Signed-off-by: Leah Rumancik <leah.rumancik@gmail.com>
> ---
> check | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/check b/check
> index d2e51296..21c00524 100755
> --- a/check
> +++ b/check
> @@ -4,7 +4,7 @@
> #
> # Control script for QA
> #
> -tmp=/tmp/$$
> +tmp=/var/tmp/$$
> status=0
> needwrap=true
> needsum=true
> @@ -46,7 +46,7 @@ export DIFF_LENGTH=${DIFF_LENGTH:=10}
> # by default don't output timestamps
> timestamp=${TIMESTAMP:=false}
>
> -rm -f $tmp.list $tmp.tmp $tmp.grep $here/$iam.out $tmp.xlist $tmp.report.*
> +rm -f $tmp.list $tmp.tmp $tmp.grep $here/$iam.out $tmp.xlist $tmp.report.* $tmp.arglist
This part looks correct though.
--D
> SRC_GROUPS="generic shared"
> export SRC_DIR="tests"
> --
> 2.39.0.rc1.256.g54fd8350bd-goog
>
next prev parent reply other threads:[~2022-12-12 23:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 23:06 [PATCH] check: use /var/tmp instead of /tmp Leah Rumancik
2022-12-12 23:18 ` Darrick J. Wong [this message]
2022-12-13 1:56 ` Leah Rumancik
2022-12-13 2:53 ` Darrick J. Wong
2022-12-14 19:56 ` Leah Rumancik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5e22dC9jxg4NnxS@magnolia \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=leah.rumancik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox