Re: [PATCH v12 0/6] fstests: add idmapped mounts tests

[Eryu Guan <guan@eryu.me>]

On Mon, Mar 29, 2021 at 12:33:54AM +0200, Christian Brauner wrote:
> From: Christian Brauner <christian.brauner@ubuntu.com>
> 
> Hey everyone,
> 
> This series is available from:
> https://git.kernel.org/brauner/xfstests-dev/h/idmapped_mounts
> https://gitlab.com/brauner/xfstests/-/tree/idmapped_mounts
> https://github.com/brauner/xfstests/tree/idmapped_mounts
> 
> /* v12 */
> - Main change is a fix to the io_uring tests. io_uring_wait_cqe()
>   doesn't set errno, it returns a negative errno.
> - Make sure we also run without error when libcap isn't available (That
>   was always the goal but the logic missed a few new tests.)

Thanks for the revision! The whole patchset looks fine to me, except
that I'm not sure if the generic/632 failure on btrfs & overlayfs is
expected.

With that resolved (either it's expected failure or test needs fix), I
think the patchset is ready to be merged.

Thanks,
Eryu

> 
> /* v11 */
> Reworked according to Amir's comments.
> 
> /* v10 */
> Reworked according to Eryu's comments.
> 
> /* v9 */
> Rebased onto current master.
> 
> ubuntu@f1-vm:~/src/git/xfstests$ sudo ./check -g idmapped
> FSTYP         -- xfs (debug)
> PLATFORM      -- Linux/x86_64 f1-vm 5.12.0-rc3-syz #18 SMP PREEMPT Fri Mar 26 13:27:16 UTC 2021
> MKFS_OPTIONS  -- -f -bsize=4096 /dev/loop1
> MOUNT_OPTIONS -- /dev/loop1 /mnt/scratch
> 
> generic/632 files ...  27s
> xfs/529 files ...  67s
> xfs/530 files ...  43s
> Ran: generic/632 xfs/529 xfs/530
> Passed all 3 tests
> 
> Thanks!
> Christian
> 
> Christian Brauner (6):
>   generic/631: add test for detached mount propagation
>   generic/632: add fstests for idmapped mounts
>   common/rc: add _scratch_{u}mount_idmapped() helpers
>   common/quota: move _qsetup() helper to common code
>   xfs/529: quotas and idmapped mounts
>   xfs/530: quotas on idmapped mounts
> 
>  .gitignore                            |    3 +
>  README                                |    5 +-
>  common/quota                          |   20 +
>  common/rc                             |   60 +
>  configure.ac                          |    2 +
>  include/builddefs.in                  |    1 +
>  m4/Makefile                           |    1 +
>  m4/package_libcap.m4                  |    4 +
>  src/Makefile                          |    8 +-
>  src/detached_mounts_propagation.c     |  189 +
>  src/feature.c                         |   40 +-
>  src/idmapped-mounts/Makefile          |   40 +
>  src/idmapped-mounts/idmapped-mounts.c | 8873 +++++++++++++++++++++++++
>  src/idmapped-mounts/missing.h         |  151 +
>  src/idmapped-mounts/mount-idmapped.c  |  431 ++
>  src/idmapped-mounts/utils.c           |  134 +
>  src/idmapped-mounts/utils.h           |   30 +
>  tests/generic/631                     |   43 +
>  tests/generic/631.out                 |    2 +
>  tests/generic/632                     |   42 +
>  tests/generic/632.out                 |    2 +
>  tests/generic/group                   |    2 +
>  tests/xfs/050                         |   19 -
>  tests/xfs/299                         |   19 -
>  tests/xfs/529                         |  377 ++
>  tests/xfs/529.out                     |  657 ++
>  tests/xfs/530                         |  212 +
>  tests/xfs/530.out                     |  129 +
>  tests/xfs/group                       |    2 +
>  29 files changed, 11453 insertions(+), 45 deletions(-)
>  create mode 100644 m4/package_libcap.m4
>  create mode 100644 src/detached_mounts_propagation.c
>  create mode 100644 src/idmapped-mounts/Makefile
>  create mode 100644 src/idmapped-mounts/idmapped-mounts.c
>  create mode 100644 src/idmapped-mounts/missing.h
>  create mode 100644 src/idmapped-mounts/mount-idmapped.c
>  create mode 100644 src/idmapped-mounts/utils.c
>  create mode 100644 src/idmapped-mounts/utils.h
>  create mode 100644 tests/generic/631
>  create mode 100644 tests/generic/631.out
>  create mode 100644 tests/generic/632
>  create mode 100644 tests/generic/632.out
>  create mode 100644 tests/xfs/529
>  create mode 100644 tests/xfs/529.out
>  create mode 100644 tests/xfs/530
>  create mode 100644 tests/xfs/530.out
> 
> 
> base-commit: f6ddaf130d5b0817278afe441fdde52f464f321b
> -- 
> 2.27.0