Re: [PATCH v12 2/6] generic/632: add fstests for idmapped mounts

Christian Brauner
2021-04-11T15:12:55Z

On Sun, Apr 11, 2021 at 10:30:20PM +0800, Eryu Guan wrote:
> On Mon, Mar 29, 2021 at 12:33:56AM +0200, Christian Brauner wrote:
> > From: Christian Brauner <christian.brauner@ubuntu.com>
> >
> > Add a test suite to verify the behavior of idmapped mounts. The test
> > suite also includes a range of vfs tests to verify that no regressions
> > are introduced by idmapped mounts. The following tests are currently
> > available with more to come in the future:
> >
> > 01. posix acls on regular and idmapped mounts
>
> I'm getting failures like below when testing on btrfs and overlayfs
>
> [root@fedoravm xfstests]# diff -u
> /root/workspace/xfstests/tests/generic/633.out /root/workspace/xfstests/results//btrfs/generic/633.out.bad
> --- /root/workspace/xfstests/tests/generic/633.out 2021-04-11 22:18: 24.458518716 +0800
> +++ /root/workspace/xfstests/results//btrfs/generic/633.out.bad 2021-04-11 22:19:58.887980770 +0800
> @@ -1,2 +1,4 @@
> QA output created by 633
> Silence is golden
> +idmapped-mounts.c: 6622: acls - Invalid argument - failure: sys_mount_setattr
> +failure: posix acls on regular mounts
>
> Is this a known issue or test needs some fix?

Ah, this is very likely just the getfacl command missing which is part
of the "acl" package, at least on Ubuntu.

Christian