Re: [PATCH v12 2/6] generic/632: add fstests for idmapped mounts

Christoph Hellwig
2021-04-12T07:22:45Z

On Sun, Apr 11, 2021 at 05:32:23PM +0200, Christian Brauner wrote:
> > > And it should actually skip the tests on all filesystems that don't
> > > support idmapped mounts which is every fs apart from xfs and ext4.
> >
> > Yeah, looks like that's the case. So it seems the _require idmapped
>
> Ah, ok I didn't know this needed to go in there. I thinke the following
> might be enough. Are you able to simply apply it on top?

No, this is broken. It needs to do feature detection, not some arbitrary
whitelists. And I'm pretty sure we got that right at some point by
doing the _notrun when mounting with the idmap option was not supported.