From: Brian Foster <bfoster@redhat.com>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] xfs/144: Use _qsetup instead of qsetup
Date: Fri, 23 Apr 2021 07:13:46 -0400 [thread overview]
Message-ID: <YIKr6oLDlYZMrHwt@bfoster> (raw)
In-Reply-To: <1619151838-22476-1-git-send-email-xuyang2018.jy@fujitsu.com>
On Fri, Apr 23, 2021 at 12:23:58PM +0800, Yang Xu wrote:
> Since xfstests commit 56908a2eb566c5("common/quota: move _qsetup() helper to common code"),
> we have common _qsetup function. Even this case doesn't use enforce value like xfs/050 and xfs/299,
> using _qsetup is more meaningful. So remove useless qsetup.
>
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> tests/xfs/144 | 21 +--------------------
> 1 file changed, 1 insertion(+), 20 deletions(-)
>
> diff --git a/tests/xfs/144 b/tests/xfs/144
> index c5995cc5..74988090 100755
> --- a/tests/xfs/144
> +++ b/tests/xfs/144
> @@ -38,25 +38,6 @@ _require_scratch
>
> rm -f $seqres.full
>
> -qsetup()
> -{
> - opt=$1
> - enforce=0
> - if [ $opt = "u" -o $opt = "uno" ]; then
> - type=u
> - eval `_choose_uid`
> - elif [ $opt = "g" -o $opt = "gno" ]; then
> - type=g
> - eval `_choose_gid`
> - elif [ $opt = "p" -o $opt = "pno" ]; then
> - type=p
> - eval `_choose_prid`
> - fi
> - [ $opt = "u" -o $opt = "g" -o $opt = "p" ] && enforce=1
> -
> - echo "Using type=$type id=$id" >> $seqres.full
> -}
> -
> exercise() {
> _scratch_mkfs_xfs | _filter_mkfs 2>$tmp.mkfs
> cat $tmp.mkfs >>$seqres.full
> @@ -66,7 +47,7 @@ exercise() {
>
> _qmount
>
> - qsetup $1
> + _qsetup $1
>
> echo "Using type=$type id=$id" >>$seqres.full
>
> --
> 2.23.0
>
prev parent reply other threads:[~2021-04-23 11:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 4:23 [PATCH] xfs/144: Use _qsetup instead of qsetup Yang Xu
2021-04-23 11:13 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIKr6oLDlYZMrHwt@bfoster \
--to=bfoster@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox