Re: [PATCH 0/7] idmapped mounts: extend testsuite and fixes

[Eryu Guan <guan@eryu.me>]

On Fri, May 07, 2021 at 05:00:53PM +0200, Christian Brauner wrote:
> From: Christian Brauner <christian.brauner@ubuntu.com>
> 
> Hey,
> 
> This introduces two new idmapped mount tests.
> The first test extends the v3 fscaps tests for idmapped mounts.
> The second test verified that idmapped mounts behave correctly when
> nested user namespaces are used. In essence it creates a fairly complex
> nested user namespace hierarchy and then tests whether file ownership
> changes are correctly reflected in all idmapped mounts as seen from all
> those user namespaces.
> In addition this fixes a couple of minor things and shares more code
> between the mount-idmapped and idmapped-mounts binaries.

I applied the first 3 patches for this update. And I think patch 4 and 7
may need some rework. Patch 5 and 6 just didn't apply without patch 4.

Thanks,
Eryu

> 
> Thanks!
> Christian
> 
> Christian Brauner (7):
>   idmapped-mounts: remove unused set_cloexec() helper
>   idmapped-mounts: add missing newline to print_r()
>   idmapped-mounts: split out run_test() function
>   generic/637: add fscaps regression test
>   idmapped-mounts: refactor helpers
>   idmapped-mounts: add nested userns creation helpers
>   generic/638: add nested user namespace tests
> 
>  .gitignore                            |   2 +
>  src/idmapped-mounts/Makefile          |  16 +-
>  src/idmapped-mounts/idmapped-mounts.c | 931 ++++++++++++++++++++++++--
>  src/idmapped-mounts/mount-idmapped.c  | 228 +------
>  src/idmapped-mounts/utils.c           | 359 ++++++++--
>  src/idmapped-mounts/utils.h           | 102 ++-
>  tests/generic/637                     |  42 ++
>  tests/generic/637.out                 |   2 +
>  tests/generic/638                     |  42 ++
>  tests/generic/638.out                 |   2 +
>  tests/generic/group                   |   2 +
>  11 files changed, 1397 insertions(+), 331 deletions(-)
>  create mode 100755 tests/generic/637
>  create mode 100644 tests/generic/637.out
>  create mode 100755 tests/generic/638
>  create mode 100644 tests/generic/638.out
> 
> 
> base-commit: 40818883aecd19581a71cc096d07eb9106c11b10
> -- 
> 2.27.0