From: Eryu Guan <guan@eryu.me>
To: David Howells <dhowells@redhat.com>
Cc: fstests@vger.kernel.org, linux-afs@lists.infradead.org
Subject: Re: [PATCH 2/9] generic/294, afs: Allow for mknod subtest failing if mknod not supported
Date: Sun, 6 Jun 2021 19:58:29 +0800 [thread overview]
Message-ID: <YLy4ZfXQ08542qoW@desktop> (raw)
In-Reply-To: <1448892.1622557912@warthog.procyon.org.uk>
On Tue, Jun 01, 2021 at 03:31:52PM +0100, David Howells wrote:
> Eryu Guan <guan@eryu.me> wrote:
>
> > _require_mknod checks for mknod support by trying to mknod and _notrun
> > the test if mknod fails.
> >
> > So does afs return any failure like EOPNOTSUPP? If so I think we could
> > refactor _require_mknod into something like
>
> afs doesn't provide a ->mknod implementation as it doesn't support anything
> you'd create with it, so you get the VFS default in such an instance - which
> would be EPERM.
I think that works too. Currently _require_mknod() doesn't depend on the
errno but just check if mknod succeeds or not.
Thanks,
Eryu
next prev parent reply other threads:[~2021-06-06 11:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 13:33 [PATCH 0/9] Add support for using xfstests to test AFS David Howells
2021-05-25 13:33 ` [PATCH 1/9] Add AFS support David Howells
2021-05-25 13:34 ` [PATCH 2/9] generic/294, afs: Allow for mknod subtest failing if mknod not supported David Howells
2021-05-25 16:09 ` Darrick J. Wong
2021-05-25 16:19 ` David Howells
2021-05-25 16:26 ` Darrick J. Wong
2021-05-30 12:49 ` Eryu Guan
2021-06-01 14:31 ` David Howells
2021-06-06 11:58 ` Eryu Guan [this message]
2021-05-25 13:34 ` [PATCH 3/9] generic/314, afs: Allow for a filesystem that doesn't honour SGID inheritance David Howells
2021-05-25 16:10 ` Darrick J. Wong
2021-05-25 13:34 ` [PATCH 4/9] generic/317, afs: Allow for a filesystem not to honour the local uid/gid David Howells
2021-05-25 16:17 ` Darrick J. Wong
2021-05-25 16:41 ` David Howells
2021-05-25 13:34 ` [PATCH 5/9] generic/123, generic/128, afs: Allow for an fs that does its own perm management David Howells
2021-05-25 16:19 ` Darrick J. Wong
2021-05-25 16:44 ` David Howells
2021-05-25 16:51 ` Darrick J. Wong
2021-05-25 13:34 ` [PATCH 6/9] Add the ability to require O_TMPFILE to be supported for a test David Howells
2021-05-25 16:19 ` Darrick J. Wong
2021-05-30 12:54 ` Eryu Guan
2021-05-25 13:34 ` [PATCH 7/9] afs: Indicate the minimum DIO alignment is 1 David Howells
2021-05-25 13:34 ` [PATCH 8/9] generic/465: Fix handling of DIO alignment < sizeof(long) David Howells
2021-05-25 16:25 ` Darrick J. Wong
2021-05-25 16:46 ` David Howells
2021-05-25 13:34 ` [PATCH 9/9] Fix other posix_memalign() alignment issues David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLy4ZfXQ08542qoW@desktop \
--to=guan@eryu.me \
--cc=dhowells@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-afs@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox