Re: [PATCH] generic/042: f2fs-utils 1.14.0 needs at least 52 MB

[Eryu Guan <guan@eryu.me>]

On Tue, Jun 01, 2021 at 04:20:05AM -0400, Sun Ke wrote:
> f2fs-utils 1.9.0 needs at least 38 MB space for f2fs image. However,
> f2fs-utils 1.14.0 needs at least 52 MB. Not sure if it will change again.
> But at least we need to configure mininum size of f2fs image to 52MB now.
> 
> Suggested-by: Chao Yu <yuchao0@huawei.com>
> Signed-off-by: Sun Ke <sunke32@huawei.com>
> ---
>  tests/generic/042 | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/generic/042 b/tests/generic/042
> index ee0e4b400c71..bf3b4180b1a2 100755
> --- a/tests/generic/042
> +++ b/tests/generic/042
> @@ -43,9 +43,12 @@ _crashtest()
>  	file=$mnt/file
>  	size=25M
>  
> -	# 25M is too small for f2fs.
> +	# f2fs-utils 1.9.0 needs at least 38 MB space for f2fs image. However,
> +	# f2fs-utils 1.14.0 needs at least 52 MB. Not sure if it will change
> +	# again. But at least we need to configure mininum size of f2fs image
> +	# to 52MB now.

It'd be better to specify a slightly bigger fs size for f2fs then. I
don't think this test depends on the fs size, just that smaller size
makes test run faster.

Maybe 64M or 128M, any suggestions from f2fs folks?

Thanks,
Eryu

>  	if [ $FSTYP == "f2fs" ]; then
> -		size=38M
> +		size=52M
>  	fi
>  
>  	# Create an fs on a small, initialized image. The pattern is written to
> -- 
> 2.25.4