Re: [PATCH] fstests: remove results .dmesg on each run

[Eryu Guan <guan@eryu.me>]

On Thu, Jul 29, 2021 at 04:32:20PM -0400, Josef Bacik wrote:
> I recently added dmesg files to my nightly fstests summary page and
> noticed I was getting .dmesg files from runs that happened previously.
> This is because we don't remove the .dmesg file in the results directory
> when we go to run the test, so fstests results would show a test having
> failed with dmesg errors when it actually hadn't failed.  Fix this by
> removing the .dmesg file when we are going to run a test.

I didn't get it, the $seqres.dmesg file being checked is generated after
each test, I didn't see how the stale $seqres.dmesg being used.

_check_dmesg()
{
	......
        _dmesg_since_test_start | $filter >$seqres.dmesg
        egrep -q -e "kernel BUG at" \
             -e "WARNING:" \
             -e "\bBUG:" \
             -e "Oops:" \
             -e "possible recursive locking detected" \
             -e "Internal error" \
             -e "(INFO|ERR): suspicious RCU usage" \
             -e "INFO: possible circular locking dependency detected" \
             -e "general protection fault:" \
             -e "BUG .* remaining" \
             -e "UBSAN:" \
             $seqres.dmesg
	......
}

Did I miss anything?

Thanks,
Eryu

> 
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> ---
>  check | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/check b/check
> index bb7e030c..2021cb21 100755
> --- a/check
> +++ b/check
> @@ -809,6 +809,7 @@ function run_section()
>  
>  		# really going to try and run this one
>  		rm -f $seqres.out.bad
> +		rm -f $seqres.dmesg
>  
>  		# check if we really should run it
>  		_expunge_test $seqnum
> -- 
> 2.26.3