From: "Theodore Ts'o" <tytso@mit.edu>
To: Pavel Reichl <preichl@redhat.com>, Murphy Zhou <xzhou@redhat.com>,
fstests@vger.kernel.org, Luis Chamberlain <mcgrof@kernel.org>
Subject: Re: [PATCH] common/rc: fix MKSWAP_PROG quoting
Date: Tue, 31 Aug 2021 13:05:10 -0400 [thread overview]
Message-ID: <YS5hRsSXNHYQdUv9@mit.edu> (raw)
In-Reply-To: <20210831134207.aa4e26xuyji4npia@fedora>
On Tue, Aug 31, 2021 at 09:42:07PM +0800, Zorro Lang wrote:
>
> Sorry, I reversed the order. I mean:
>
> $MKSWAP_PROG "$fname" 2>&1 >> $seqres.full | grep -v "insecure permission"
That looks right, although I might have done something like this:
filter_mkswap_stderr()
{
grep -v "insecure permission"
}
...
$MKSWAP_PROG "$fname" 2>&1 >> $seqres.full | filter_mkswap_stderr
More for the documentation effect rather than the abstraction. But I
wouldn't insist on it; some folks might consider this to be excess
levels abstraction.
- Ted
next prev parent reply other threads:[~2021-08-31 17:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 3:04 [PATCH] common/rc: fix MKSWAP_PROG quoting Murphy Zhou
2021-08-31 5:26 ` Zorro Lang
2021-08-31 7:38 ` Pavel Reichl
2021-08-31 13:42 ` Zorro Lang
2021-08-31 17:05 ` Theodore Ts'o [this message]
2021-09-01 6:16 ` [PATCH v2] " Murphy Zhou
2021-09-01 7:15 ` Dave Chinner
2021-09-01 9:40 ` [PATCH v3] " Xiong Zhou
2021-09-03 17:48 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YS5hRsSXNHYQdUv9@mit.edu \
--to=tytso@mit.edu \
--cc=fstests@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=preichl@redhat.com \
--cc=xzhou@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox