Re: generic/095 failing in ext4 and xfs

Ming Lei
2021-10-11T11:14:15Z

On Mon, Oct 11, 2021 at 11:16:09AM +0100, Luís Henriques wrote:
> On Mon, Oct 11, 2021 at 05:31:44PM +0800, Ming Lei wrote:
> > On Mon, Oct 11, 2021 at 10:09:30AM +0100, Luís Henriques wrote:
> > > On Sun, Oct 10, 2021 at 04:31:25PM +0800, Zorro Lang wrote:
> > > > On Fri, Oct 01, 2021 at 06:11:49PM +0100, Luis Henriques wrote:
> > > > > Hi!
> > > > >
> > > > > I'm seeing generic/095 failing both with ext4 and xfs (but not on btrfs).
> > > > > Here's what I'm getting:
> > > > >
> > > > > # cat results/generic/095.out.bad
> > > > > QA output created by 095
> > > > > fio: io_u error on file /tmp/mnt/scratch/file1: Invalid argument: read offset=51200, buflen=1024
> > > > > fio: io_u error on file /tmp/mnt/scratch/file1: Invalid argument: read offset=133120, buflen=1024
> > > > > fio: io_u error on file /tmp/mnt/scratch/file2: Invalid argument: write offset=92160, buflen=1024
> > > > > fio: io_u error on file /tmp/mnt/scratch/file2: Invalid argument: write offset=158720, buflen=1024
> > > > > fio: io_u error on file /tmp/mnt/scratch/file2: Invalid argument: write offset=513024, buflen=1024
> > > > > fio: io_u error on file /tmp/mnt/scratch/file2: Invalid argument: write offset=33792, buflen=1024
> > > > > fio: io_u error on file /tmp/mnt/scratch/file2: Invalid argument: write offset=449536, buflen=1024
> > > > > fio: io_u error on file /tmp/mnt/scratch/file1: Invalid argument: read offset=45056, buflen=1024
> > > > > fio: io_u error on file /tmp/mnt/scratch/file1: Invalid argument: read offset=30720, buflen=1024
> > > > > fio: io_u error on file /tmp/mnt/scratch/file1: Invalid argument: write offset=222208, buflen=1024
> > > > > fio: io_u error on file /tmp/mnt/scratch/file1: Invalid argument: read offset=342016, buflen=1024
> > > > > fio: io_u error on file /tmp/mnt/scratch/file1: Invalid argument: write offset=177152, buflen=1024
> > > > > fio: pid=4090, got signal=11
> > > > > fio: io_u error on file /tmp/mnt/scratch/file1: Invalid argument: write offset=43008, buflen=1024
> > > > > fio: io_u error on file /tmp/mnt/scratch/file1: Invalid argument: write offset=308224, buflen=1024
> > > > > fio: pid=4086, got signal=11
> >
> > The issue should be from generic/095 test itself, which run dio with bs=1k,
> > but logical block size is 4k. I guess the test may work after you change
> > bs to 4k in generic/095.
>
> Ah, I see what you mean. Ok, I've used the patch bellow and the test now
> passes. The patch changes the block size only for the DIO jobs, there are
> other jobs where bs=1k is still used. Do you think other jobs should be
> changed as well?

Only DIO job need aligned bs parameter.

thanks,
Ming