public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <guan@eryu.me>
To: "Zhu, YifeiX" <yifeix.zhu@intel.com>
Cc: "fstests@vger.kernel.org" <fstests@vger.kernel.org>,
	"Li, Philip" <philip.li@intel.com>,
	"Ma, XinjianX" <xinjianx.ma@intel.com>,
	"Li, ZhijianX" <zhijianx.li@intel.com>
Subject: Re: [PATCH xfstests] btrfs/012: check size after mounted
Date: Mon, 25 Oct 2021 00:00:46 +0800	[thread overview]
Message-ID: <YXWDLlCbosV3UWEl@desktop> (raw)
In-Reply-To: <DM6PR11MB39324F4B7F5EB9B686DE29B084BF9@DM6PR11MB3932.namprd11.prod.outlook.com>

On Thu, Oct 21, 2021 at 01:59:04AM +0000, Zhu, YifeiX wrote:
> check the disk size is enougth for test, should move '_require_fs_space'  after mounted.
> fix error:
> btrfs/012       [not run] This test requires at least 0GB free on /fs/scratch to run
> 
>  Signed-off-by: Zhu Yifei <yifeix.zhu@intel.com>
> ---
>  tests/btrfs/012 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/btrfs/012 b/tests/btrfs/012 index 46341e9..8b11cf9 100755
> --- a/tests/btrfs/012
> +++ b/tests/btrfs/012
> @@ -29,8 +29,6 @@ _require_command "$BTRFS_CONVERT_PROG" btrfs-convert  _require_command "$MKFS_EXT4_PROG" mkfs.ext4  _require_command "$E2FSCK_PROG" e2fsck

This patch doesn't apply, and it seems the above context is somwhow
merged into one line, would you please double check?

>  
> -_require_fs_space $SCRATCH_MNT $(du -s /lib/modules/`uname -r` | ${AWK_PROG} '{print $1}')
> -
>  BLOCK_SIZE=`_get_block_size $TEST_DIR`
>  
>  # Create & populate an ext4 filesystem
> @@ -39,6 +37,8 @@ $MKFS_EXT4_PROG -F -b $BLOCK_SIZE $SCRATCH_DEV > $seqres.full 2>&1 || \  # Manual mount so we don't use -t btrfs or selinux context  mount -t ext4 $SCRATCH_DEV $SCRATCH_MNT
>  
> +_require_fs_space $SCRATCH_MNT $(du -s /lib/modules/`uname -r` | 

Trailing whitespace introduced in above line.

Thanks,
Eryu

> +${AWK_PROG} '{print $1}')
> +
>  cp -aR /lib/modules/`uname -r`/ $SCRATCH_MNT  _scratch_unmount
>  
> --
> 1.8.3.1

      reply	other threads:[~2021-10-24 16:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21  1:59 [PATCH xfstests] btrfs/012: check size after mounted Zhu, YifeiX
2021-10-24 16:00 ` Eryu Guan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXWDLlCbosV3UWEl@desktop \
    --to=guan@eryu.me \
    --cc=fstests@vger.kernel.org \
    --cc=philip.li@intel.com \
    --cc=xinjianx.ma@intel.com \
    --cc=yifeix.zhu@intel.com \
    --cc=zhijianx.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox