From: Eryu Guan <guan@eryu.me>
To: An Long <lan@suse.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] btrfs/099: Fix qgroupid issue
Date: Sun, 5 Dec 2021 21:59:23 +0800 [thread overview]
Message-ID: <YazFu0fDehuQlBUt@desktop> (raw)
In-Reply-To: <20211201144610.26002-1-lan@suse.com>
On Wed, Dec 01, 2021 at 10:46:10PM +0800, An Long wrote:
> The qgroup commands now accepts the level/id format. Use 0/subvolid to
> avoid invalid qgroupid error.
>
> Signed-off-by: An Long <lan@suse.com>
Thanks for the fix! But this has been fixed by commit e4746f0dcd1e
("btrfs/099: use the qgroupid for qgroup limit"), would you please pull
the latest code and check if that fixes the issue for you?
Thanks,
Eryu
P.S.
Please also cc btrfs list in future for btrfs-specific patches.
Similarly for patches for other filesystems.
> ---
> tests/btrfs/099 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/btrfs/099 b/tests/btrfs/099
> index 375cc2b9..f3a2002a 100755
> --- a/tests/btrfs/099
> +++ b/tests/btrfs/099
> @@ -29,7 +29,7 @@ _scratch_mount
> _require_fs_space $SCRATCH_MNT $(($FILESIZE * 2 / 1024))
>
> _run_btrfs_util_prog quota enable $SCRATCH_MNT
> -_run_btrfs_util_prog qgroup limit $FILESIZE 5 $SCRATCH_MNT
> +_run_btrfs_util_prog qgroup limit $FILESIZE 0/5 $SCRATCH_MNT
>
> # loop 5 times without sync to ensure reserved space leak will happen
> for i in `seq 1 5`; do
> --
> 2.31.1
prev parent reply other threads:[~2021-12-05 13:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 14:46 [PATCH] btrfs/099: Fix qgroupid issue An Long
2021-12-05 13:59 ` Eryu Guan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YazFu0fDehuQlBUt@desktop \
--to=guan@eryu.me \
--cc=fstests@vger.kernel.org \
--cc=lan@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).