public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH -v2] common/filter: add _filter_bash()
Date: Sat, 18 Dec 2021 23:24:37 -0600	[thread overview]
Message-ID: <Yb7CFcU09vtaFx79@quark.localdomain> (raw)
In-Reply-To: <20211219041638.1659557-1-tytso@mit.edu>

On Sat, Dec 18, 2021 at 11:16:38PM -0500, Theodore Ts'o wrote:
> This is needed to account for bash 5.1 adding line number annotation
> when executing a command via the -c option and it fails.  For example,
> "bash -c 'echo foo > /'" will cause bash 5.1 to report:
> 
>      bash: line 1: /: Is a directory
> 
> instead of:
> 
>      bash: /: Is a directory
> 
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> ---
>  common/filter     | 11 +++++++++++
>  tests/generic/572 | 33 +++++++++++++++++++--------------
>  2 files changed, 30 insertions(+), 14 deletions(-)

Reviewed-by: Eric Biggers <ebiggers@google.com>

- Eric

      reply	other threads:[~2021-12-19  5:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-14 17:04 [PATCH] common/filter: add _filter_bash() Theodore Ts'o
2021-12-16  0:54 ` Eric Biggers
2021-12-18 17:10   ` Theodore Ts'o
2021-12-19  2:34     ` Eric Biggers
2021-12-19  4:16       ` [PATCH -v2] " Theodore Ts'o
2021-12-19  5:24         ` Eric Biggers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yb7CFcU09vtaFx79@quark.localdomain \
    --to=ebiggers@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox