From: "Luís Henriques" <lhenriques@suse.de>
To: Jeff Layton <jlayton@kernel.org>
Cc: fstests@vger.kernel.org
Subject: Re: [fstests PATCH] ceph: don't run tests if we can't set a custom layout
Date: Thu, 9 Dec 2021 11:18:01 +0000 [thread overview]
Message-ID: <YbHl6WCyneP1AWy3@suse.de> (raw)
In-Reply-To: <20211207160437.184145-1-jlayton@kernel.org>
On Tue, Dec 07, 2021 at 11:04:37AM -0500, Jeff Layton wrote:
> Some of the coming fscrypt patches prohibit non-default layout changes.
> Skip running the tests that set custom layouts if setting the layout fails.
>
> Cc: Luis Henriques <lhenriques@suse.de>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> common/ceph | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/ceph b/common/ceph
> index ca756dda8dd3..31b169af51b8 100644
> --- a/common/ceph
> +++ b/common/ceph
> @@ -19,7 +19,7 @@ _ceph_create_file_layout()
> touch $fname
> $SETFATTR_PROG -n ceph.file.layout \
> -v "stripe_unit=$objsz stripe_count=1 object_size=$objsz" \
> - $fname
> + $fname || _notrun "setting ceph.file.layout failed"
> }
>
> # this test requires to access file capabilities through vxattr 'ceph.caps'.
> --
> 2.33.1
>
Yeah, this is a simple way to skip those tests. Feel free to add my
Reviewed-by: Luis Henriques <lhenriques@suse.de>
Cheers,
--
Luís
next prev parent reply other threads:[~2021-12-09 11:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 16:04 [fstests PATCH] ceph: don't run tests if we can't set a custom layout Jeff Layton
2021-12-09 11:18 ` Luís Henriques [this message]
2021-12-12 14:02 ` Eryu Guan
2021-12-15 13:16 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbHl6WCyneP1AWy3@suse.de \
--to=lhenriques@suse.de \
--cc=fstests@vger.kernel.org \
--cc=jlayton@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox