From: Eryu Guan <guan@eryu.me>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] common/module: fix patient module remover when module is not present
Date: Sun, 12 Dec 2021 20:59:07 +0800 [thread overview]
Message-ID: <YbXyG4OPA2Yfw9/K@desktop> (raw)
In-Reply-To: <YbOwrpa7SoJqErvZ@bombadil.infradead.org>
On Fri, Dec 10, 2021 at 11:55:26AM -0800, Luis Chamberlain wrote:
> Poke
Sorry, it got lost from my to-review queue, applied now, thanks!
Eryu
>
> On Mon, Nov 15, 2021 at 03:28:34PM -0800, Luis Chamberlain wrote:
> > When module is not present and the open coded patient module
> > remover is called we'll end up in a loop which never ends.
> > Fix this.
> >
> > I actually found this issue not in fstests, but when applying this
> > open coded solution to blktests. In fstest we tend to only call
> > module remove when we have a module loaded. blktests is different,
> > and so I immediately spotted the issue there.
> >
> > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> > ---
> > common/module | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/common/module b/common/module
> > index ead0f881..6efab71d 100644
> > --- a/common/module
> > +++ b/common/module
> > @@ -180,6 +180,8 @@ _patient_rmmod()
> > continue
> > fi
> > let max_tries=$max_tries-1
> > + else
> > + break
> > fi
> > done
> >
> > --
> > 2.33.0
> >
prev parent reply other threads:[~2021-12-12 12:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 23:28 [PATCH] common/module: fix patient module remover when module is not present Luis Chamberlain
2021-12-10 19:55 ` Luis Chamberlain
2021-12-12 12:59 ` Eryu Guan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbXyG4OPA2Yfw9/K@desktop \
--to=guan@eryu.me \
--cc=fstests@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).