From: "Theodore Ts'o" <tytso@mit.edu>
To: Eryu Guan <guan@eryu.me>
Cc: fstests@vger.kernel.org, Eric Whitney <enwlinux@gmail.com>
Subject: Re: [PATCH] ext4/033: remove a portion of the test assuming resize2fs would fail
Date: Mon, 20 Dec 2021 15:39:21 -0500 [thread overview]
Message-ID: <YcDp+SLrwqUNBox4@mit.edu> (raw)
In-Reply-To: <Yb9M3aIb9cJGIJaB@desktop>
On Sun, Dec 19, 2021 at 11:16:45PM +0800, Eryu Guan wrote:
>
> This portion of test is the key of the original regression test, if
> we're going to remove this part, does it make sense to remove ext4/033
> completely?
Hmm, good point. It's nice to keep the regression test around, but we
can't use resize2fs to test the kernel's online resize code directly.
We can fix this by creating test program to execute the ioctl
directly. Revised patch coming....
- Ted
next prev parent reply other threads:[~2021-12-20 20:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 3:54 [PATCH] ext4/033: remove a portion of the test assuming resize2fs would fail Theodore Ts'o
2021-12-19 15:16 ` Eryu Guan
2021-12-20 20:39 ` Theodore Ts'o [this message]
2021-12-20 20:40 ` [PATCH] ext4/033: test EXT4_IOC_RESIZE_FS by calling the ioctl directly Theodore Ts'o
2022-01-05 15:57 ` Zorro Lang
2022-01-05 16:06 ` Zorro Lang
2022-01-05 20:02 ` Theodore Ts'o
2022-01-06 2:35 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcDp+SLrwqUNBox4@mit.edu \
--to=tytso@mit.edu \
--cc=enwlinux@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).