FS/XFS testing framework
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Gabriel Krisman Bertazi <krisman@collabora.com>,
	zlang@redhat.com, fstests@vger.kernel.org
Subject: Re: [PATCH] generic/556: Adequate expected output to touch behavior change
Date: Thu, 19 May 2022 13:31:59 -0400	[thread overview]
Message-ID: <YoZ/DzUTB73Cs8Ki@mit.edu> (raw)
In-Reply-To: <YoVl7MVtEUuupODz@sol.localdomain>

On Wed, May 18, 2022 at 02:32:28PM -0700, Eric Biggers wrote:
> 
> This would break the test on systems that still have an older version of
> coreutils, right?  For example, currently kvm-xfstests test appliances are based
> on Debian Bullseye by default, which isn't very old, but it has coreutils 8.32.

Even Debian unstable is still using coreutils 8.32:

   https://packages.debian.org/search?keywords=coreutils&searchon=names&suite=all&section=all

> Can you filter the output to allow the test to pass with both old and new
> coreutils versions?

Gabriel, FYI, the filter functions live in common/filter.  There are a
large number of them see "git log common/filter" to see how they get
added.  For a really simple example, please see commit 90d132ee44b7:

    common/filter: add _filter_bash()
    
    This is needed to account for bash 5.1 adding line number annotation
    when executing a command via the -c option and it fails.  For example,
    "bash -c 'echo foo > /'" will cause bash 5.1 to report:
    
         bash: line 1: /: Is a directory
    
    instead of:
    
         bash: /: Is a directory

Cheers,

						- Ted

      parent reply	other threads:[~2022-05-19 17:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18 20:22 [PATCH] generic/556: Adequate expected output to touch behavior change Gabriel Krisman Bertazi
2022-05-18 21:32 ` Eric Biggers
2022-05-18 22:11   ` Darrick J. Wong
2022-05-19 17:31   ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YoZ/DzUTB73Cs8Ki@mit.edu \
    --to=tytso@mit.edu \
    --cc=ebiggers@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=krisman@collabora.com \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox