From: "Luís Henriques" <lhenriques@suse.de>
To: Zorro Lang <zlang@kernel.org>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] ceph/002: fix test expected output
Date: Tue, 7 Jun 2022 15:30:54 +0100 [thread overview]
Message-ID: <Yp9hHodpGwM+5ZKK@suse.de> (raw)
In-Reply-To: <20220522095628.hgkhd2xchud4p3c5@zlang-mailbox>
On Sun, May 22, 2022 at 05:56:28PM +0800, Zorro Lang wrote:
> On Fri, May 20, 2022 at 08:37:47PM +0800, Zorro Lang wrote:
> > On Fri, May 20, 2022 at 10:47:09AM +0100, Luís Henriques wrote:
> > > Commit daa0c0146c7d ("fstests: replace hexdump with od command") broke
> > > ceph/002 by adding an extra '0' in the offset column. Fix it.
> > >
> > > Signed-off-by: Luís Henriques <lhenriques@suse.de>
> > > ---
> >
> > Oh, that's my bad, I changed that in daa0c014 ("fstests: replace hexdump
> > with od command"), but write an extra '0' for ceph/002.out [1]. And due to
> > I don't test cephfs, so missed this failure. Thanks for fixing it!
> >
> > Reviewed-by: Zorro Lang <zlang@redhat.com>
>
> Hi Luís,
>
> Sorry, I just noticed that I missed this one in this week fstests release, I'll
> merge and push it in next weekend (05.29) :)
>
Ping. Looks like this hasn't yet been merged.
Cheers,
--
Luís
> Thanks,
> Zorro
>
> >
> > [1]
> > ...
> > diff --git a/tests/ceph/002.out b/tests/ceph/002.out
> > index 6f067250..f7f1c0ba 100644
> > --- a/tests/ceph/002.out
> > +++ b/tests/ceph/002.out
> > @@ -1,8 +1,8 @@
> > QA output created by 002
> > -0000000 6161 6161 6161 6161 6161 6161 6161 6161
> > +000000 61 61 61 61 61 61 61 61 61 61 61 61 61 61 61 61 >aaaaaaaaaaaaaaaa<
> > *
> > -0400000 6262 6262 6262 6262 6262 6262 6262 6262
> > +400000 62 62 62 62 62 62 62 62 62 62 62 62 62 62 62 62 >bbbbbbbbbbbbbbbb<
> > *
> > -0800000 6363 6363 6363 6363 6363 6363 6363 6363
> > +800000 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63 >cccccccccccccccc<
> > *
> > -0c00000
> > +c000000
> > ...
> >
> > > tests/ceph/002.out | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tests/ceph/002.out b/tests/ceph/002.out
> > > index f7f1c0ba8487..4f766c257a9c 100644
> > > --- a/tests/ceph/002.out
> > > +++ b/tests/ceph/002.out
> > > @@ -5,4 +5,4 @@ QA output created by 002
> > > *
> > > 800000 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63 >cccccccccccccccc<
> > > *
> > > -c000000
> > > +c00000
> > >
prev parent reply other threads:[~2022-06-07 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 9:47 [PATCH] ceph/002: fix test expected output Luís Henriques
2022-05-20 12:37 ` Zorro Lang
2022-05-22 9:56 ` Zorro Lang
2022-05-23 8:10 ` Luís Henriques
2022-06-07 14:30 ` Luís Henriques [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yp9hHodpGwM+5ZKK@suse.de \
--to=lhenriques@suse.de \
--cc=fstests@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox