From: Eric Biggers <ebiggers@kernel.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Zorro Lang <zlang@redhat.com>, fstests@vger.kernel.org
Subject: Re: [PATCH -v3 7/7] ext4: create file systems with the encrypt feature as necessary
Date: Wed, 29 Jun 2022 21:20:51 +0000 [thread overview]
Message-ID: <YrzCM/Ti9WLzYS6N@gmail.com> (raw)
In-Reply-To: <YryoPGksgK3UfKvO@mit.edu>
On Wed, Jun 29, 2022 at 03:30:04PM -0400, Theodore Ts'o wrote:
> On Wed, Jun 29, 2022 at 09:30:52PM +0800, Zorro Lang wrote:
> >
> > As Eric gave some review points to V2, so double check with Eric, if it's good
> > to him?
>
> Eric, any other issues than the ones which you had mentioned (and
> which I have addressed)?
Well, not all the comments I made on v2 were addressed; see
https://lore.kernel.org/fstests/YrvgMkrXh8iUItVv@sol.localdomain.
As I said, the overall approach is fine though.
- Eric
next prev parent reply other threads:[~2022-06-29 21:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 12:45 [PATCH -v3 0/7] Miscellaneous ext4 test fix ups Theodore Ts'o
2022-06-29 12:45 ` [PATCH -v3 1/7] ext4/050: support indirect as well as extent mapped journals Theodore Ts'o
2022-06-29 12:45 ` [PATCH -v3 2/7] ext4/044: skip test if the file system does not have a journal Theodore Ts'o
2022-06-29 13:11 ` Zorro Lang
2022-06-29 12:45 ` [PATCH -v3 3/7] ext4/045: _require_dumpe2fs doesn't take any arguments so remove them Theodore Ts'o
2022-06-29 13:12 ` Zorro Lang
2022-06-29 12:45 ` [PATCH -v3 4/7] ext4/054: skip test if the dax mount option is enabled Theodore Ts'o
2022-06-29 12:45 ` [PATCH -v3 5/7] ext4/055: skip test if dax mount option is used Theodore Ts'o
2022-06-29 13:15 ` Zorro Lang
2022-06-29 12:45 ` [PATCH -v3 6/7] ext4/035: skip this test if the scratch device does not support 1k block sizes Theodore Ts'o
2022-06-29 13:14 ` Zorro Lang
2022-06-29 12:45 ` [PATCH -v3 7/7] ext4: create file systems with the encrypt feature as necessary Theodore Ts'o
2022-06-29 13:30 ` Zorro Lang
2022-06-29 19:30 ` Theodore Ts'o
2022-06-29 21:20 ` Eric Biggers [this message]
2022-06-30 1:39 ` Zorro Lang
2022-06-30 14:45 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrzCM/Ti9WLzYS6N@gmail.com \
--to=ebiggers@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox