FS/XFS testing framework
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: fstests@vger.kernel.org
Cc: David Disseldorp <ddiss@suse.de>
Subject: Re: [PATCH -v2] report: add support for the xunit-quiet format
Date: Mon, 11 Jul 2022 12:10:31 -0400	[thread overview]
Message-ID: <YsxLd2f9CxDZH05I@mit.edu> (raw)
In-Reply-To: <20220711160436.2102299-1-tytso@mit.edu>

On Mon, Jul 11, 2022 at 12:04:36PM -0400, Theodore Ts'o wrote:
> The xunit-quiet format exludes the NNN.{full,dmesg,bad} files in

Oops, sorry this should have beeb ***includes*** the
NNN.{full,dmesg,bad} files....

> <system-out> and <system-err> nodes.
> 
> For test runners that save the entire results directory to preserve
> all of the test artifacts, capturing the NNN.{full,dmesg,bad} in the
> results.xml file is redundant.  In addition, if the NNN.bad is too
> large, it can cause the junitparser python library to refuse to parse
> the XML file to prevent potential denial of service attacks[1].  A
> simple way to avoid this problem is to simply to omit the <system-out>
> and <system-err> nodes in the results.xml file.
> 
> [1] https://gitlab.com/gitlab-org/gitlab/-/issues/268035
> 
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> Reviewed-by: David Disseldorp <ddiss@suse.de>

      reply	other threads:[~2022-07-11 16:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-11 16:04 [PATCH -v2] report: add support for the xunit-quiet format Theodore Ts'o
2022-07-11 16:10 ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YsxLd2f9CxDZH05I@mit.edu \
    --to=tytso@mit.edu \
    --cc=ddiss@suse.de \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox