From: Eric Biggers <ebiggers@kernel.org>
To: Nathan Huckleberry <nhuck@google.com>
Cc: fstests@vger.kernel.org, linux-fscrypt@vger.kernel.org,
Sami Tolvanen <samitolvanen@google.com>
Subject: Re: [RFC PATCH v4 2/2] generic: add tests for fscrypt policies with HCTR2
Date: Tue, 19 Jul 2022 12:51:10 -0700 [thread overview]
Message-ID: <YtcLLnjm90td0lqP@sol.localdomain> (raw)
In-Reply-To: <20220601071811.1353635-3-nhuck@google.com>
On Wed, Jun 01, 2022 at 12:18:11AM -0700, Nathan Huckleberry wrote:
> diff --git a/tests/generic/900 b/tests/generic/900
> new file mode 100755
> index 00000000..d1496007
> --- /dev/null
> +++ b/tests/generic/900
> @@ -0,0 +1,28 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright 2022 Google LLC
> +#
> +# FS QA Test No. generic/900
> +#
> +# Verify ciphertext for v2 encryption policies that use AES-256-XTS to encrypt
> +# file contents and AES-256-HCTR2 to encrypt file names.
> +#
How about mentioning here the commit that introduced this feature upstream?
Otherwise this patch looks good.
- Eric
prev parent reply other threads:[~2022-07-19 19:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 7:18 [RFC PATCH v4 0/2] generic: test HCTR2 filename encryption Nathan Huckleberry
2022-06-01 7:18 ` [RFC PATCH v4 1/2] fscrypt-crypt-util: add HCTR2 implementation Nathan Huckleberry
2022-07-19 19:49 ` Eric Biggers
2022-06-01 7:18 ` [RFC PATCH v4 2/2] generic: add tests for fscrypt policies with HCTR2 Nathan Huckleberry
2022-07-19 19:51 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtcLLnjm90td0lqP@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=nhuck@google.com \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox