From: "Darrick J. Wong" <djwong@kernel.org>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] xfs/191: Add missing xfsprogs commit
Date: Wed, 27 Jul 2022 20:54:42 -0700 [thread overview]
Message-ID: <YuIIggUZXat6Lp2F@magnolia> (raw)
In-Reply-To: <1658982991-3860-1-git-send-email-xuyang2018.jy@fujitsu.com>
On Thu, Jul 28, 2022 at 12:36:31PM +0800, Yang Xu wrote:
> xfs_repair also needs to think empty xattr leaf block isn't corruption, so
> case can pass.
>
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
Yep, thanks.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> tests/xfs/191 | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/tests/xfs/191 b/tests/xfs/191
> index c568f90e..a10077fe 100755
> --- a/tests/xfs/191
> +++ b/tests/xfs/191
> @@ -11,9 +11,11 @@
> # operations don't stumble over them, and that xfs_repair will offer to remove
> # the entire xattr fork if the root xattr leaf block is empty.
> #
> -# Regression test for kernel commit:
> -#
> +# Regression test for
> +# kernel commit:
> # 7be3bd8856fb ("xfs: empty xattr leaf header blocks are not corruption")
> +# xfsprogs commit:
> +# f50d3462c654 ("xfs_repair: ignore empty xattr leaf blocks")
> #
> . ./common/preamble
> _begin_fstest auto quick attr
> @@ -28,6 +30,7 @@ _supported_fs xfs
> _require_scratch
> _require_scratch_xfs_crc # V4 is deprecated
> _fixed_by_kernel_commit 7be3bd8856fb "xfs: empty xattr leaf header blocks are not corruption"
> +_fixed_by_git_commit xfsprogs f50d3462c654 "xfs_repair: ignore empty xattr leaf blocks"
>
> _scratch_mkfs_xfs | _filter_mkfs >$seqres.full 2>$tmp.mkfs
> cat $tmp.mkfs >> $seqres.full
> --
> 2.23.0
>
prev parent reply other threads:[~2022-07-28 3:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 4:36 [PATCH] xfs/191: Add missing xfsprogs commit Yang Xu
2022-07-28 3:54 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuIIggUZXat6Lp2F@magnolia \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox