Re: [PATCH] fstests: add more dmerror related test cases into eio group

["Darrick J. Wong" <djwong@kernel.org>]

On Sun, Jul 31, 2022 at 12:46:50PM +0800, Zorro Lang wrote:
> The g/484, g/628 and g/629 calls _dmerror_init and load error table
> for testing, better to count them in eio test group, then we won't
> miss them when we want to run all eio related cases.
> 
> Signed-off-by: Zorro Lang <zlang@kernel.org>

Looks correct to me,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  tests/generic/484 | 2 +-
>  tests/generic/628 | 2 +-
>  tests/generic/629 | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/generic/484 b/tests/generic/484
> index 40e83cbd..4f413352 100755
> --- a/tests/generic/484
> +++ b/tests/generic/484
> @@ -15,7 +15,7 @@
>  #    buffer: record blockdev write errors in super_block that it backs
>  
>  . ./common/preamble
> -_begin_fstest auto quick
> +_begin_fstest auto quick eio
>  
>  # Override the default cleanup function.
>  _cleanup()
> diff --git a/tests/generic/628 b/tests/generic/628
> index 7dc6dfcd..380a7f0b 100755
> --- a/tests/generic/628
> +++ b/tests/generic/628
> @@ -11,7 +11,7 @@
>  # 5ffce3cc22a0 ("xfs: force the log after remapping a synchronous-writes file")
>  
>  . ./common/preamble
> -_begin_fstest auto quick rw clone
> +_begin_fstest auto quick rw clone eio
>  
>  # Override the default cleanup function.
>  _cleanup()
> diff --git a/tests/generic/629 b/tests/generic/629
> index f501555e..dbd7ada8 100755
> --- a/tests/generic/629
> +++ b/tests/generic/629
> @@ -11,7 +11,7 @@
>  # 5ffce3cc22a0 ("xfs: force the log after remapping a synchronous-writes file")
>  
>  . ./common/preamble
> -_begin_fstest auto quick rw copy_range
> +_begin_fstest auto quick rw copy_range eio
>  
>  # Override the default cleanup function.
>  _cleanup()
> -- 
> 2.31.1
>