From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3970C00144 for ; Thu, 4 Aug 2022 05:15:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238383AbiHDFPS (ORCPT ); Thu, 4 Aug 2022 01:15:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231201AbiHDFPR (ORCPT ); Thu, 4 Aug 2022 01:15:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3128A21B5; Wed, 3 Aug 2022 22:15:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C0D9F617BA; Thu, 4 Aug 2022 05:15:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B993C433C1; Thu, 4 Aug 2022 05:15:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659590115; bh=kqdpnd+R819QEG2l0B0YBG8bKlSaEhGZWl09ldGsuIs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Mfg/j+1Ie65H9ds0s/kdJ3WK+Vjv/Bhp50Cwy97iXeRPr0XiyhuMfULs2AZ2h68Zx QhlYwTTCz+u0Ih4WVKxp4kknysozKnLCy+q76g3ihRalhRUPVAzyJUQOdYU5EFIkfy eP6XhknUtzo8+QYEr/P9FVrSrZii1n8j+5smNsZkxV5hzQq0v5qIGLed7QBMDVuZWY ZxeUiB3fJABc2SDKIHn5NBXH4eNQ3rXsnw4pkHLqzAYlClB2m7IpCk9zfeuqAawngE tBFHNQR7D0+w48+SOHKWlYZ7MoqiBTdnALs3UqGHthyDwme6BenqulIW7e0OqAiU2t DnpWY0Kn2MoRQ== Date: Wed, 3 Aug 2022 22:15:14 -0700 From: "Darrick J. Wong" To: "xuyang2018.jy@fujitsu.com" Cc: "guaneryu@gmail.com" , "zlang@redhat.com" , "linux-xfs@vger.kernel.org" , "fstests@vger.kernel.org" , "guan@eryu.me" Subject: Re: [PATCH 3/3] xfs/533: fix golden output for this test Message-ID: References: <165950048029.198815.11843926234080013062.stgit@magnolia> <165950049724.198815.5496412458825635633.stgit@magnolia> <4094bf3b-9be0-c629-648a-b78999e3ec83@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Wed, Aug 03, 2022 at 10:06:16PM -0700, Darrick J. Wong wrote: > On Thu, Aug 04, 2022 at 01:53:31AM +0000, xuyang2018.jy@fujitsu.com wrote: > > on 2022/08/03 12:21, Darrick J. Wong wrote: > > > From: Darrick J. Wong > > > > > > Not sure what's up with this new test, but the golden output isn't right > > > for upstream xfsprogs for-next. Change it to pass there... > > > > It failed becuase libxfs code validates v5 feature fields. > > > > b12d5ae5d ("xfs: validate v5 feature fields") > > > > > > Signed-off-by: Darrick J. Wong > > > --- > > > tests/xfs/533.out | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > diff --git a/tests/xfs/533.out b/tests/xfs/533.out > > > index 7deb78a3..439fb16e 100644 > > > --- a/tests/xfs/533.out > > > +++ b/tests/xfs/533.out > > > @@ -1,5 +1,5 @@ > > > QA output created by 533 > > > Allowing write of corrupted data with good CRC > > > magicnum = 0 > > > -bad magic number > > Ohhh, so this is a V4 output. > > > > +Superblock has bad magic number 0x0. Not an XFS filesystem? > > > > Since this case is designed to detect xfs_db bug, should we filter the > > output? > > Yep. I'll rework this patch to handle V4 and V5. Well, thanks for > keeping me on my toes! ;) Hmm, V4 produces this: --- /tmp/fstests/tests/xfs/533.out 2022-08-02 19:02:12.876335795 -0700 +++ /var/tmp/fstests/xfs/533.out.bad 2022-08-03 22:12:43.596000000 -0700 @@ -1,5 +1,3 @@ QA output created by 533 -Allowing write of corrupted data with good CRC magicnum = 0 -Superblock has bad magic number 0x0. Not an XFS filesystem? 0 So I guess this isn't a V4 output. Which version of xfsprogs and what MKFS_OPTIONS did you use to make this to produce 'bad magic number'? --D > --D > > > Best Regards > > Yang Xu > > > 0 > > >