From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: guaneryu@gmail.com, zlang@redhat.com, linux-xfs@vger.kernel.org,
fstests@vger.kernel.org, guan@eryu.me
Subject: Re: [PATCH 1/2] common: refactor fail_make_request boilerplate
Date: Thu, 11 Aug 2022 05:36:08 -0700 [thread overview]
Message-ID: <YvT3uHD3iBu+jsB4@infradead.org> (raw)
In-Reply-To: <165950053513.199134.15842568650897036461.stgit@magnolia>
> +_start_fail_scratch_dev()
> +_stop_fail_scratch_dev()
I still think passing an explicit device here vs having specific
helpers for the scratch device would be better. But overall we
need to do this refatoring and given that the patch looks otherwise
good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2022-08-11 12:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 4:22 [PATCHSET v2 0/2] fstests: enhance fail_make_request Darrick J. Wong
2022-08-03 4:22 ` [PATCH 1/2] common: refactor fail_make_request boilerplate Darrick J. Wong
2022-08-11 12:36 ` Christoph Hellwig [this message]
2022-08-03 4:22 ` [PATCH 2/2] fail_make_request: teach helpers about external devices Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2022-07-26 19:48 [PATCHSET 0/2] fstests: enhance fail_make_request Darrick J. Wong
2022-07-26 19:49 ` [PATCH 1/2] common: refactor fail_make_request boilerplate Darrick J. Wong
2022-07-28 19:01 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvT3uHD3iBu+jsB4@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox