From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Theodore Ts'o <tytso@mit.edu>, fstests@vger.kernel.org
Subject: Re: [PATCH 2/2] generic/530: only use xfs-specific mkfs options when testing on xfs
Date: Thu, 19 Dec 2024 09:26:06 +1100 [thread overview]
Message-ID: <Z2NL_oc5QSscZdZ_@dread.disaster.area> (raw)
In-Reply-To: <Z2EyG0vqtyTSyM5a@infradead.org>
On Tue, Dec 17, 2024 at 12:11:07AM -0800, Christoph Hellwig wrote:
> On Sun, Dec 15, 2024 at 12:12:42AM -0500, Theodore Ts'o wrote:
> > +if [ $FSTYP = "xfs" ]; then
> > + _scratch_mkfs "-l size=256m" >> $seqres.full 2>&1
> > +else
> > + _scratch_mkfs >> $seqres.full 2>&1
> > +fi
>
> We really need to document why generic tests have file system specific
> hacks. And yes, that's a request for Dave who originally added it
> without any explanation and not Ted.
Creating and then unlinking 50000 files is journal space bound
when using default 64MB logs on small test filesystems. Increasing
the journal size to 256MB halved the runtime of this test.
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2024-12-18 22:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-15 5:12 [PATCH 0/2] Fix recent regressions from for_next Theodore Ts'o
2024-12-15 5:12 ` [PATCH 1/2] generic/135: don't try to rm $SCRATCH_MNT/* Theodore Ts'o
2024-12-17 8:11 ` Christoph Hellwig
2024-12-15 5:12 ` [PATCH 2/2] generic/530: only use xfs-specific mkfs options when testing on xfs Theodore Ts'o
2024-12-17 8:11 ` Christoph Hellwig
2024-12-18 22:26 ` Dave Chinner [this message]
2024-12-19 5:37 ` Christoph Hellwig
2024-12-19 10:16 ` Zorro Lang
2024-12-19 16:32 ` Darrick J. Wong
2024-12-19 20:49 ` Dave Chinner
2024-12-19 22:53 ` Darrick J. Wong
2024-12-20 15:11 ` Eric Sandeen
2024-12-22 12:22 ` Zorro Lang
2024-12-22 14:22 ` Zorro Lang
2024-12-18 22:26 ` [PATCH 0/2] Fix recent regressions from for_next Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2NL_oc5QSscZdZ_@dread.disaster.area \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox