Re: [PATCH 2/2] dio_writeback_race: align the directio buffer to base page size

Christoph Hellwig
2025-02-19T05:51:06Z

On Tue, Feb 18, 2025 at 04:49:31PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> There's no need to align the memory buffer for the direcio write to the
> file allocation unit size; base page size will do. This fixes the
> following error when generic/761 is run against an XFS rt filesystem
> with a 28k rtextsize:

Note that in theory even just the memory alignment reported by
statx / XFS_IOC_DIOINFO is enough, but I don't see how reducing the
alignment futher would benefit us much here.

Reviewed-by: Christoph Hellwig <hch@lst.de>