Re: [PATCH 09/13] xfs: skip tests if formatting small filesystem fails

Darrick J. Wong
2025-02-19T17:13:38Z

On Tue, Feb 18, 2025 at 11:30:57PM -0800, Christoph Hellwig wrote:
> On Tue, Feb 18, 2025 at 05:05:59PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > There are a few tests that try to exercise XFS functionality with an
> > unusually small (< 500MB) filesystem. Formatting can fail if the test
> > configuration also specifies a very large realtime device because mkfs
> > hits ENOSPC when allocating the realtime metadata. The test proceeds
> > anyway (which causes an immediate mount failure) so we might as well
> > skip these.
>
> In this patch only a single test case is touched and not a few. But
> I remember hitting a few more with the zoned testing.

Originally there were a few more, but most of the others I fixed by
making _scratch_mkfs_sized constrict the size of both the data and rt
volumes. The 2022 version of this patch changed both xfs/104 and
xfs/291.

Oh, wait, the xfs/291 change became its own patch.

Right. _scratch_mkfs_sized takes arguments now. So this patch should
make create_scratch() use that instead of plain _scratch_mkfs_xfs.

--D