From: Christoph Hellwig <hch@infradead.org>
To: Josef Bacik <josef@toxicpanda.com>
Cc: Christoph Hellwig <hch@infradead.org>,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH 1/3] fstests: check btrfs profile configs before allowing raid56
Date: Thu, 21 Mar 2024 14:37:42 -0700 [thread overview]
Message-ID: <Zfyopg6JY9-M7AFA@infradead.org> (raw)
In-Reply-To: <20240320144019.GB3014929@perftesting>
On Wed, Mar 20, 2024 at 10:40:19AM -0400, Josef Bacik wrote:
> The tests that use this are testing them both. I could make them optionally
> test one or the other depending on the profile you had set, but I don't think
> this is particularly useful. If you have strong feelings about it I could
> alternatively add a helper that is
>
> _require_raid_profile "profile name"
>
> and then add those to the different tests to be more fine grained about it,
> since technically this helper is about checking if a specific kernel feature is
> available. Thanks,
That seems a bit more useful, but it looks like others have even
better idea here in the thread, so I'll shut up.
next prev parent reply other threads:[~2024-03-21 21:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 16:55 [PATCH 0/3] fstests: various RAID56 related fixes for btrfs Josef Bacik
2024-03-19 16:55 ` [PATCH 1/3] fstests: check btrfs profile configs before allowing raid56 Josef Bacik
2024-03-19 20:59 ` Christoph Hellwig
2024-03-20 14:40 ` Josef Bacik
2024-03-21 21:37 ` Christoph Hellwig [this message]
2024-03-20 12:31 ` Anand Jain
2024-03-20 14:41 ` Josef Bacik
2024-03-19 16:55 ` [PATCH 2/3] fstests: btrfs/195: skip raid setups not in the profile configs Josef Bacik
2024-03-24 14:25 ` Anand Jain
2024-03-19 16:55 ` [PATCH 3/3] fstests: add _require_btrfs_fs_feature raid56 to a few tests Josef Bacik
2024-03-21 5:55 ` Naohiro Aota
2024-03-24 14:16 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zfyopg6JY9-M7AFA@infradead.org \
--to=hch@infradead.org \
--cc=fstests@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox