Re: [PATCH v2 1/2] shared: move btrfs clone device testcase to the shared group

Christoph Hellwig
2024-03-21T21:41:08Z

On Wed, Mar 20, 2024 at 05:08:02PM +0100, David Sterba wrote:
> This could work, the number of exceptions is short:
>
> tests/generic:
> 547 _supported_fs generic
> 4 _supported_fs ^nfs
> 2 _supported_fs ^overlay
> 1 _supported_fs ^xfs
> 1 _supported_fs ^btrfs ^nfs
> 1 _supported_fs ^btrfs
>
> The example from generic/187:
>
> # btrfs can't fragment free space. This test is unreliable on NFS, as it
> # depends on the exported filesystem.
> _supported_fs ^btrfs ^nfs
>
> There are different reasons for the exclusion but at least for btrfs
> could be transformed to e.g.
>
> _require_can_fragment_free_space
>
> Not sure about the NFS part, it can be either excluding remote
> filesystems or mandating a local one.

I think the same applies for NFS. The underlying fs on the other
side might or might not allow fragmenting free space, but it doesn't
matter to NFS testing.

(then again reading through the actual test I have no idea what it has
to do with fragmenting freespace vs just stressing the test, and
I hope not work / unreliable just means it takes forever as no
one should be corrupting files with this workload).