FS/XFS testing framework
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Zorro Lang <zlang@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	David Sterba <dsterba@suse.com>,
	fstests@vger.kernel.org
Subject: Re: [PATCH 1/4] Move shared/032 to generic/740
Date: Thu, 9 May 2024 05:41:20 -0700	[thread overview]
Message-ID: <ZjzEcG8Z1_Ly2x-X@infradead.org> (raw)
In-Reply-To: <20240509100016.ov23vek643renv36@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>

On Thu, May 09, 2024 at 06:00:16PM +0800, Zorro Lang wrote:
> Yeah, that's the reason I still keep the shared as a "prefix directory"
> of generic. The hardcode whitelist or blacklist of _supported_fs is a
> bit rude. If a fs isn't supported by a test case totally, that's fine.
> But if the condition of _notrun can be smaller and more precise (refer
> to some _require_xxx helpers) that would be great.
> 
> Of course we can move shared to generic at first, then improve it later.
> But I doubt if we can keep that in mind, due to there're hundreds of
> generic cases :)

# git-grep _supported_fs tests/generic/ | grep -v generic

will do the job.  But before this turns into an endless discussion
I can just sign up for adding the proper helpers after the merge
is applied.


  reply	other threads:[~2024-05-09 12:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-07 19:07 [PATCH 0/4] Move test cased from shared to generic David Sterba
2024-05-07 19:07 ` [PATCH 1/4] Move shared/032 to generic/740 David Sterba
2024-05-07 22:38   ` Darrick J. Wong
2024-05-09  5:40   ` Christoph Hellwig
2024-05-09 10:00     ` Zorro Lang
2024-05-09 12:41       ` Christoph Hellwig [this message]
2024-05-07 19:07 ` [PATCH 2/4] Move shared/002 to generic/745 David Sterba
2024-05-09  5:40   ` Christoph Hellwig
2024-05-09 16:34     ` David Sterba
2024-05-07 19:07 ` [PATCH 3/4] Move shared/298 to generic/746 David Sterba
2024-05-09  5:41   ` Christoph Hellwig
2024-05-07 19:07 ` [PATCH 4/4] Remove rest of shared/ David Sterba
2024-05-07 22:39 ` [PATCH 0/4] Move test cased from shared to generic Darrick J. Wong
2024-05-09  5:29 ` Zorro Lang
2024-05-09 16:28   ` David Sterba
2024-05-10  1:43     ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZjzEcG8Z1_Ly2x-X@infradead.org \
    --to=hch@infradead.org \
    --cc=dsterba@suse.com \
    --cc=fstests@vger.kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox