FS/XFS testing framework
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: fstests@vger.kernel.org
Subject: can we pull in git as a dependency for xfstests?
Date: Mon, 10 Jun 2024 22:41:41 -0700	[thread overview]
Message-ID: <ZmfjlWGk04r_R5j6@infradead.org> (raw)

xfs/073 has been failing for me for a while on most of my test setups
with:

diff: memory exhausted

from the recursive diff.  Switching to the significantly more memory
efficient implementation in git diff as in the patch below fixes this.

Would it be ok to pull in diff (including a supported check)?

diff --git a/tests/xfs/073 b/tests/xfs/073
index c7616b9e9..85d8ae8d0 100755
--- a/tests/xfs/073
+++ b/tests/xfs/073
@@ -76,7 +76,7 @@ _verify_copy()
 	fi
 
 	echo comparing new image files to old
-	diff -Naur $source_dir $target_dir
+	git diff --no-index $source_dir $target_dir
 
 	echo comparing new image directories to old
 	find $source_dir | _filter_path $source_dir > $tmp.manifest1

             reply	other threads:[~2024-06-11  5:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-11  5:41 Christoph Hellwig [this message]
2024-06-11 14:24 ` can we pull in git as a dependency for xfstests? Darrick J. Wong
2024-06-11 16:25   ` Christoph Hellwig
2024-06-12  4:58 ` Zorro Lang
2024-06-12  5:10   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZmfjlWGk04r_R5j6@infradead.org \
    --to=hch@infradead.org \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox