From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2603D3EDE77 for ; Thu, 23 Jul 2026 09:09:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784797763; cv=none; b=o8FQ3NlIabM3xjsT9WkPIXT4mEEMKYjd0Mb1EXSfNUEeVAV2zCoie//ZQ4G+Uj3pk2X1iwZIwb0FoKarpmgxCm+DwAvRK4+FJU5/tr8IECS9nOx/xEwTeRppgxbYIJPCS2EeFIOH5ukipIyz/UzZOUCFXolN6uxlBIB5BPQ6Tp8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784797763; c=relaxed/simple; bh=JIDV8ufu5CaMdKMvf9AWU0wQ2PQmEJ5FKAdHwip4B2I=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=LGFAYGsMDH/uYqhsfbYAb1qz4cBJBsC/FEleWPnktYPVzKz/M7vwfIk6Qv5IjNHebDm8koWHrAJ1psFxeNyAE6ZjKzDiOofyAe9WQqvqYqPSXryaBZtqCBGtGF0kcMJKDzA+pwCa5u9Y6s5vbWXEqXBAB/RYNOgdAJs+wY3iuDY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 574F61F000E9; Thu, 23 Jul 2026 09:09:20 +0000 (UTC) Message-ID: Date: Thu, 23 Jul 2026 17:09:12 +0800 Precedence: bulk X-Mailing-List: fstests@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, Anand Suveer Jain , fstests@vger.kernel.org, jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net, "Darrick J. Wong" Subject: Re: [PATCH v2] common/rc: support f2fs in _require_fanotify_ioerrors() To: Zorro Lang References: <20260706064326.3657995-1-chao@kernel.org> <5c11cd98-bb41-46e0-9765-e2aad57a08e4@kernel.org> Content-Language: en-US From: Chao Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/17/26 18:47, Zorro Lang wrote: > On Wed, Jul 08, 2026 at 11:25:37AM +0800, Chao Yu wrote: >> On 7/7/26 18:13, Anand Suveer Jain wrote: >>> On 6/7/26 14:43, Chao Yu wrote: >>>> f2fs has supported to report fserror, this patch adds support for f2fs >>>> in _require_fanotify_ioerrors(), so that we can run generic/791 on f2fs. >>>> >>>> Cc: Darrick J. Wong >>>> Signed-off-by: Chao Yu >>>> --- >>>> common/rc | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>>> diff --git a/common/rc b/common/rc >>>> index 494725547..f51ad59f3 100644 >>>> --- a/common/rc >>>> +++ b/common/rc >>>> @@ -6257,6 +6257,9 @@ _require_fanotify_ioerrors() >>>> x="$(_get_fs_sysfs_attr $TEST_DEV err_report_sec)" >>>> test -n "$x" && return 0 >>>> ;; >>> >>> >>>> + f2fs) >>>> + x="$(cat /sys/fs/f2fs/features/fserror)" >>>> + test -n "$x" && return 0 >>> >>> Don't we need to check if /sys/fs/f2fs/features/fserror >>> is present in the running kernel (there are helpers) >> >> Hi Anand, >> >> You mean _has_fs_sysfs_attr()? however, it forces to check first parameter $dev >> w/ block device type: >> >> if [ ! -b "$dev" -o -z "$attr" ];then >> _fail "Usage: _has_fs_sysfs_attr " >> fi > > Hi Chao and Anand, > > The *_fs_sysfs related helpers were brought in by me in: > commit 2a7b77abcd1dde735186b363da24540706c43b73 > Author: Zorro Lang > Date: Tue Jul 5 17:30:24 2016 +0800 > > xfs: configurable behavior on errors at unmount time > > At that time, I didn't think about the "features/" directory. > > Now, let me rethink this set of helpers. I feel that the *_fs_sysfs > family of functions shouldn't be restricted to the $dev directory, > we should remove this restriction. > > Following that, we bring in *_fs_sysfs_device (appending the _device suffix) > helpers which call *_fs_sysfs(). Also change the test cases who call these > functions. > > Finally, we can introduce the *_fs_sysfs_features functions (or simply use > *_fs_sysfs directly). > > Also, we have both *_fs_sysfs_attr and *_fs_sysfs, and the logic between > them is somewhat confusing and easy to mix up. Zorro, It makes sense, and good news to their user. Thanks for the proposal. > > I need to write a series of patches to clean up these logic. For this current > patch, we can start with a small-scale change first. What do you think? So I will use this first: f2fs) local feat_file="/sys/fs/f2fs/features/fserror" if [ -f "$feat_file" ] && [ "$(cat "$feat_file")" = "supported" ]; then return 0 fi ;; And then waiting for your cleanup? or if you want to clean up this, please do it directly while merging. Thanks, > > Thanks, > Zorro > >> >> >>> before reading it? >> >> How about this? >> >> f2fs) >> local feat_file="/sys/fs/f2fs/features/fserror" >> if [ -f "$feat_file" ] && [ "$(cat "$feat_file")" = "supported" ]; then >> return 0 >> fi >> ;; >> >>> >>> >>> >>>> esac >>>> >>>> _notrun "$FSTYP does not support fanotify ioerrors" >>> >>