Re: [PATCH] generic/798: exclude nfs from cachestat dirty page reporting test

[Avinesh Kumar <avinesh.kumar@suse.com>]

Hello Darrick,


>> diff --git a/tests/generic/798 b/tests/generic/798
>> index 0fe37646..80b2acc9 100755
>> --- a/tests/generic/798
>> +++ b/tests/generic/798
>> @@ -16,6 +16,12 @@ _require_scratch
>>   _exclude_scratch_mount_option "dax"
>>   _exclude_scratch_mount_option "sync"
>>   
>> +# NFS flushes dirty data back to the server on close() as part of its
>> +# close-to-open cache consistency model, so a page written and closed in
>> +# one xfs_io invocation is no longer dirty by the time cachestat runs in
>> +# a later invocation.
>> +_exclude_fs nfs
> 
> Could you just chain all the xfs_io commands together into a single
> invocation?
> 
> $XFS_IO_PROG -f \
> 	-c "pwrite -b $pagesize 0 $size" \
> 	-c "cachestat 0 $size" \
> 	-c "fsync" \
> 	-c "cachestat 0 $size" \
> 	$SCRATCH_MNT/foobar
> 
> to solve this problem?
> 

Thanks for the review and this suggestion. Chaining all xfs_io commands
together seems to work, with also passing '-q' to pwrite to suppress
these lines -
     +wrote 4096/4096 bytes at offset 0
     +4 KiB, 1 ops; 0.0000 sec (355.114 MiB/sec and 90909.0909 ops/sec)

I am sending revised patch.

Regards,
Avinesh