Re: [PATCH 1/2] fsstress: don't abort when stat(".") returns EIO

[Christoph Hellwig <hch@infradead.org>]

On Tue, Jul 29, 2025 at 01:10:50PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> First, start with the premise that fstests is run with a nonzero limit
> on the size of core dumps so that we can capture the state of
> misbehaving fs utilities like fsck and scrub if they crash.

Can you explain what this has to do with core dumping?

I'm just really confused between this patch content and the subject of
this patch and the entire series..

> This is really silly, because basic stat requests for the current
> working directory can be satisfied from the inode cache without a disk
> access.  In this narrow situation, EIO only happens when the fs has shut
> down, so just exit the program.

If we think it's silly we can trivially drop the xfs_is_shutdown check
in xfs_vn_getattr.  But is it really silly?  We've tried to basically
make every file system operation consistently fail on shut down
file systems,

> We really should have a way to query if a filesystem is shut down that
> isn't conflated with (possibly transient) EIO errors.  But for now this
> is what we have to do. :(

Well, a new STATX_ flag would work, assuming stat doesn't actually
fail :)  Otherwise a new ioctl/fcntl would make sense, especially as
the shutdown concept has spread beyond XFS.