Re: [PATCH 6/8] common/filter: fix _filter_file_attributes to handle xfs file flags

Christoph Hellwig
2025-10-20T07:01:22Z

On Fri, Oct 17, 2025 at 09:22:18AM -0700, Darrick J. Wong wrote:
> > What XFS flags end up in lsattr?
>
> Assuming you're asking which XFS flags are reported by ext4 lsattr...
>
> append, noatime, nodump, immutable, projinherit, fsdax
>
> Unless you meant src/file_attr.c? In which case theyr'e

I'm actually not sure. I was just surprised about the flags showing
up.

>
> > Is this coordinated with the official
> > registry in ext4?
>
> Only informally by Ted and I talking on Thursdays.
>
> The problem here is that _filter_file_attributes ... probably ought to
> say which domain (ext4 lsattr or xfs_io lsattr) it's actually filtering.

Oooh. That explains my confusion.

> Right now the only users of this helper are using it to filter
> src/file_attr.c output (aka xfs_io lsattr) so I think I should change
> the patch to document that.

Yes, please. And we really need to figure out central authoritisied
to document the lsattr and fsxattr domain flags.