Re: [PATCH 6/8] common/filter: fix _filter_file_attributes to handle xfs file flags

Darrick J. Wong
2025-10-17T16:22:19Z

On Thu, Oct 16, 2025 at 09:23:44PM -0700, Christoph Hellwig wrote:
> On Wed, Oct 15, 2025 at 09:38:16AM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Currently, _filter_file_attributes can only filter ext4 lsattr flags.
> > Update it to handle XFS lsattr flags as well.
>
> What XFS flags end up in lsattr?

Assuming you're asking which XFS flags are reported by ext4 lsattr...

append, noatime, nodump, immutable, projinherit, fsdax

Unless you meant src/file_attr.c? In which case theyr'e

> Is this coordinated with the official
> registry in ext4?

Only informally by Ted and I talking on Thursdays.

The problem here is that _filter_file_attributes ... probably ought to
say which domain (ext4 lsattr or xfs_io lsattr) it's actually filtering.

Right now the only users of this helper are using it to filter
src/file_attr.c output (aka xfs_io lsattr) so I think I should change
the patch to document that.

--D