Re: [PATCH 6/8] common/filter: fix _filter_file_attributes to handle xfs file flags

Darrick J. Wong
2025-10-21T14:47:51Z

On Mon, Oct 20, 2025 at 10:30:29PM -0700, Christoph Hellwig wrote:
> On Mon, Oct 20, 2025 at 09:37:13AM -0700, Darrick J. Wong wrote:
> > [add tytso and linux-ext4]
> >
> > I think we should standardize on the VFS (aka file_getattr) flag values,
> > which means the xfs version more or less wins.
>
> Ok, I'm more than confused than before. Shouldn't we simply use
> separate filters for FS_IOC_GETFLAGS vs FS_IOC_FSGETXATTR?

Yeah. I was going to just provide both versions, but then I went down
the rabbithole of navelgazing about "Is upstream going to accept a
helper for the ext4 lsattr flags even though there are no users?" and
then wandered off to tackle actual useful things like mount/unmount
races in fuse. :P

--D