From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: zlang@redhat.com, fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 06/11] common/filter: fix _filter_file_attributes to handle src/file_attr.c file flags
Date: Tue, 21 Oct 2025 21:18:16 -0700 [thread overview]
Message-ID: <aPhbCKGUsM182Hvi@infradead.org> (raw)
In-Reply-To: <176107188777.4163693.5636086769178869317.stgit@frogsfrogsfrogs>
On Tue, Oct 21, 2025 at 11:40:46AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Currently, _filter_file_attributes filters ext4 lsattr flags, but it's
> only callers (all introduced in 4eb4017) are using it to filter the file
> attribute letters from src/file_attr.c. These correspond to the flags
> defined by the new file_getattr system call, so let's rename the helper
> to make it clear we're filtering *VFS* attribute characters, and change
> the code to filter all known characters from that interface.
Thanks, with this commit message even me understands what's going on now
:)
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-10-22 4:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 18:39 [PATCHSET 1/2] fstests: more random fixes for v2025.10.05 Darrick J. Wong
2025-10-21 18:39 ` [PATCH 01/11] generic/427: try to ensure there's some free space before we do the aio test Darrick J. Wong
2025-10-21 18:39 ` [PATCH 02/11] common/rc: fix _require_xfs_io_shutdown Darrick J. Wong
2025-10-21 18:39 ` [PATCH 03/11] generic/742: avoid infinite loop if no fiemap results Darrick J. Wong
2025-10-21 18:40 ` [PATCH 04/11] generic/{482,757}: skip test if there are no FUA writes Darrick J. Wong
2025-10-22 4:17 ` Christoph Hellwig
2025-10-21 18:40 ` [PATCH 05/11] generic/772: actually check for file_getattr special file support Darrick J. Wong
2025-10-21 18:40 ` [PATCH 06/11] common/filter: fix _filter_file_attributes to handle src/file_attr.c file flags Darrick J. Wong
2025-10-22 4:18 ` Christoph Hellwig [this message]
2025-10-21 18:41 ` [PATCH 07/11] common/attr: fix _require_noattr2 Darrick J. Wong
2025-10-21 18:41 ` [PATCH 08/11] common: fix _require_xfs_io_command pwrite -A for various blocksizes Darrick J. Wong
2025-10-21 18:41 ` [PATCH 09/11] generic/778: fix severe performance problems Darrick J. Wong
2025-10-22 4:20 ` Christoph Hellwig
2025-10-22 4:27 ` Darrick J. Wong
2025-10-31 17:47 ` Darrick J. Wong
2025-11-01 9:34 ` Zorro Lang
2025-11-01 15:42 ` Darrick J. Wong
2025-11-01 16:22 ` Zorro Lang
2025-10-21 18:41 ` [PATCH 10/11] check: line up stdout columns Darrick J. Wong
2025-10-22 4:21 ` Christoph Hellwig
2025-10-21 18:42 ` [PATCH 11/11] fsx: don't print messages when atomic writes are explicitly disabled Darrick J. Wong
2025-10-22 4:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPhbCKGUsM182Hvi@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox