FS/XFS testing framework
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Joanne Chang <joannechien@google.com>
Cc: Zorro Lang <zlang@kernel.org>,
	fstests@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
	linux-f2fs-devel@lists.sourceforge.net, Chao Yu <chao@kernel.org>
Subject: Re: [PATCH v1] generic/735: disable for f2fs
Date: Wed, 17 Dec 2025 23:33:06 -0800	[thread overview]
Message-ID: <aUOuMmZnw3tij2nj@infradead.org> (raw)
In-Reply-To: <20251218071717.2573035-1-joannechien@google.com>

On Thu, Dec 18, 2025 at 07:17:17AM +0000, Joanne Chang wrote:
> generic/735 attempts to create a file with nearly 2^32 blocks. However,
> the maximum block count per file in F2FS is limited by the capacity of
> the inode. This limit is roughly 2^30 blocks, which is significantly
> lower than the test's requirement.
> 
> Signed-off-by: Joanne Chang <joannechien@google.com>
> ---
>  tests/generic/735 | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/generic/735 b/tests/generic/735
> index 9bbdf3a1..d5ba5673 100755
> --- a/tests/generic/735
> +++ b/tests/generic/735
> @@ -19,6 +19,9 @@ if [[ "$FSTYP" =~ ext[0-9]+ ]]; then
>  	_fixed_by_kernel_commit 2dcf5fde6dff "ext4: prevent the normalized size from exceeding EXT_MAX_BLOCKS"
>  fi
>  
> +# Block number 0xffffffff is too big for a file in f2fs.
> +_exclude_fs f2fs

Please don't add random file system excludes.  This should be
abstracted into a _require_max_file_size helper or similar.


  reply	other threads:[~2025-12-18  7:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-18  7:17 [PATCH v1] generic/735: disable for f2fs Joanne Chang
2025-12-18  7:33 ` Christoph Hellwig [this message]
2025-12-18 12:02   ` Joanne Chang
2025-12-19  5:30     ` Christoph Hellwig
2025-12-19  8:53       ` Joanne Chang
2025-12-19 11:10         ` Christoph Hellwig
2025-12-22  2:48           ` Joanne Chang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aUOuMmZnw3tij2nj@infradead.org \
    --to=hch@infradead.org \
    --cc=chao@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=joannechien@google.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox