From: Christoph Hellwig <hch@infradead.org>
To: Joanne Chang <joannechien@google.com>
Cc: Zorro Lang <zlang@kernel.org>,
fstests@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net, Chao Yu <chao@kernel.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v2] common/rc: add _require_blocks_in_file helper
Date: Tue, 6 Jan 2026 22:08:40 -0800 [thread overview]
Message-ID: <aV34aGUeU0pQkwj2@infradead.org> (raw)
In-Reply-To: <20251229023145.1806877-1-joannechien@google.com>
On Mon, Dec 29, 2025 at 02:31:45AM +0000, Joanne Chang wrote:
> generic/735 attempts to create a file with nearly 2^32 blocks. However,
> some filesystems have a maximum file block limit below this threshold.
> For instance, F2FS is limited to approximately 2^30 blocks due to the
> capacity of the inode. So add _require_blocks_in_file helper to skip the
> test in such cases.
I still don't understand why we can't do this programmatically. I guess
it would be simply too slow? In that case that should probably be
documented here in the commit log. Otherwise this looks good to me.
next prev parent reply other threads:[~2026-01-07 6:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 2:31 [PATCH v2] common/rc: add _require_blocks_in_file helper Joanne Chang
2026-01-04 14:42 ` Chao Yu
2026-01-07 6:08 ` Christoph Hellwig [this message]
2026-01-07 8:12 ` Joanne Chang
2026-01-07 8:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aV34aGUeU0pQkwj2@infradead.org \
--to=hch@infradead.org \
--cc=chao@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=jaegeuk@kernel.org \
--cc=joannechien@google.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox