Re: [PATCH v2] common/rc: add _require_blocks_in_file helper

Christoph Hellwig
2026-01-07T08:18:01Z

On Wed, Jan 07, 2026 at 04:12:44PM +0800, Joanne Chang wrote:
> On Wed, Jan 7, 2026 at 2:08 PM Christoph Hellwig <hch@infradead.org> wrote:
> > I still don't understand why we can't do this programmatically. I guess
> > it would be simply too slow? In that case that should probably be
> > documented here in the commit log. Otherwise this looks good to me.
>
> I used a constant to avoid masking bugs that cause the maximum file size
> to shrink on filesystems that should support this test. I can add the
> reason to the commit message if that would make it clearer.

That would be great, thanks!