Re: [PATCH v2] common/rc: add _require_blocks_in_file helper

Christoph Hellwig
2026-01-07T06:08:41Z

On Mon, Dec 29, 2025 at 02:31:45AM +0000, Joanne Chang wrote:
> generic/735 attempts to create a file with nearly 2^32 blocks. However,
> some filesystems have a maximum file block limit below this threshold.
> For instance, F2FS is limited to approximately 2^30 blocks due to the
> capacity of the inode. So add _require_blocks_in_file helper to skip the
> test in such cases.

I still don't understand why we can't do this programmatically. I guess
it would be simply too slow? In that case that should probably be
documented here in the commit log. Otherwise this looks good to me.