From: Christoph Hellwig <hch@infradead.org>
To: Joanne Chang <joannechien@google.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Zorro Lang <zlang@kernel.org>,
fstests@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net, Chao Yu <chao@kernel.org>
Subject: Re: [PATCH v2] common/rc: add _require_blocks_in_file helper
Date: Wed, 7 Jan 2026 00:18:00 -0800 [thread overview]
Message-ID: <aV4WuCaMl7I2TQAd@infradead.org> (raw)
In-Reply-To: <CACQK4XCF-Hex_H31evMu8Zpv_OLtV0QBU0MpajOSHcfaREMAKw@mail.gmail.com>
On Wed, Jan 07, 2026 at 04:12:44PM +0800, Joanne Chang wrote:
> On Wed, Jan 7, 2026 at 2:08 PM Christoph Hellwig <hch@infradead.org> wrote:
> > I still don't understand why we can't do this programmatically. I guess
> > it would be simply too slow? In that case that should probably be
> > documented here in the commit log. Otherwise this looks good to me.
>
> I used a constant to avoid masking bugs that cause the maximum file size
> to shrink on filesystems that should support this test. I can add the
> reason to the commit message if that would make it clearer.
That would be great, thanks!
prev parent reply other threads:[~2026-01-07 8:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 2:31 [PATCH v2] common/rc: add _require_blocks_in_file helper Joanne Chang
2026-01-04 14:42 ` Chao Yu
2026-01-07 6:08 ` Christoph Hellwig
2026-01-07 8:12 ` Joanne Chang
2026-01-07 8:18 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aV4WuCaMl7I2TQAd@infradead.org \
--to=hch@infradead.org \
--cc=chao@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=jaegeuk@kernel.org \
--cc=joannechien@google.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox