[PATCH] t_readdir_3: Allow EOF on ignore_error

[PATCH] t_readdir_3: Allow EOF on ignore_error

[Shahar Hochma]

ignore_error is used when providing random input to setpos.
This can, by chance, produce a valid response from readdir,
but with EOF. In which case, we don't want the test to fail.

Signed-off-by: Shahar Hochma <shaharhoch@gmail.com>
---
 src/t_readdir_3.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/t_readdir_3.c b/src/t_readdir_3.c
index 8f9bb326..5d7afddc 100644
--- a/src/t_readdir_3.c
+++ b/src/t_readdir_3.c
@@ -52,12 +52,12 @@ static void libc_getentry(struct dirent *entry)
 	errno = 0;
 	ret = readdir(dir);
 	if (!ret) {
+		if (ignore_error)
+			return;
 		if (errno == 0) {
 			fprintf(stderr, "Unexpected EOF while reading dir.\n");
 			exit(1);
 		}
-		if (ignore_error)
-			return;
 		perror("readdir");
 		exit(1);
 	}
@@ -92,6 +92,8 @@ static void kernel_getentry(struct dirent *entry)
 		exit(1);
 	}
 	if (ret == 0) {
+		if (ignore_error)
+			return;
 		fprintf(stderr, "Unexpected EOF while reading dir.\n");
 		exit(1);
 	}
-- 
2.52.0.351.gbe84eed79e-goog

Re: [PATCH] t_readdir_3: Allow EOF on ignore_error

[Christoph Hellwig]

On Sun, Jan 04, 2026 at 12:28:16PM +0200, Shahar Hochma wrote:
> ignore_error is used when providing random input to setpos.
> This can, by chance, produce a valid response from readdir,
> but with EOF. In which case, we don't want the test to fail.

Just curious: how did you run into this?

Re: [PATCH] t_readdir_3: Allow EOF on ignore_error

[Christoph Hellwig]

On Wed, Jan 07, 2026 at 10:36:30AM +0200, Shahar Hochma wrote:
> I'm working on an NFS server solution and we use XFS tests as part of our
> CI. This test failed sporadically, and we found the issue while investing
> the failure.

Adding that you saw failures on NFS would be really useful.  Especially
as NFS vs setpos is pretty special in general.