From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D8FF2E11D2; Fri, 6 Feb 2026 06:26:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770359173; cv=none; b=rMuVtFYEpSz8h6XP+3O/Zm/KWt0eZJ2Kl/T8oVAmerdmtMUP/QoBxK3Ivk3aVyC0F4lOUCIZjRrmAJXUQJ4OsrJ8Iu/GKiYZrXfqG3tVLNPIGVij3SV07g8sqxpfsH1tXaVbP17Pg525QjH2+Fu2teC0nna3pJgy0YpRV1Q42ls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770359173; c=relaxed/simple; bh=HSEcY+AmfonRTX1o20RwTTeaFjnSoRBIo6axDNOfEN8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PNk+3M1cdI6PU+d2ij5FwK4lmOdbIwP8VEZUCMgE+XB0DYY03wK+WzAJa0sDDGAf9Ivo0abmKjWwj14wzsjcTWW42C42dogZ/G5WZbYGDLaWxAVnkW8DKRVHB8aPBH5yHb+rypM4kLTpHfvb300voif//UCXPQt5EkiHTpz/yKc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=k6ngIGnw; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="k6ngIGnw" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bJB45Vb4k/+G1p59CEuJEsFMT+4qltm1VSjsyCW4hfs=; b=k6ngIGnwoNdzgFyb6eR70CiMnx xDy/+5IU4mULlNf9fcRGor5KB9jf0feFO2NfHRndqoVI19Js/aqizu9plYZsWT+jDapJAg0IiyotX V8y+VXdXCHSreKX1IRenVmRjLP2+rtJQ+3bcFZNGKc62yYipDfK4paw8eNZ2ybcPPUKM6kNiLayMg nAQmV8eUhD9MFUnsax2bORCURg8sL7EJUY0to16W9LnhisEPN0wBv2DsR8itB6wQhuRNae8FaiOwR +tzW+uVjAQF1mzE1rbmL6BuE4Y8FKDXTw04QREACUJcGLWIp+GEkLEXgld8OJ67lEh/rqTvmVlqrz 61WflkXw==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1voFIC-0000000Awkc-167I; Fri, 06 Feb 2026 06:26:12 +0000 Date: Thu, 5 Feb 2026 22:26:12 -0800 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , zlang@redhat.com, linux-ext4@vger.kernel.org, fstests@vger.kernel.org Subject: Re: [PATCH 1/3] xfs/018: remove inline xattr recovery tests Message-ID: References: <177005945267.2432878.7105483366958924034.stgit@frogsfrogsfrogs> <177005945298.2432878.17951687824065765554.stgit@frogsfrogsfrogs> <20260205165624.GA7703@frogsfrogsfrogs> <20260206062222.GN7686@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: fstests@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260206062222.GN7686@frogsfrogsfrogs> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Thu, Feb 05, 2026 at 10:22:22PM -0800, Darrick J. Wong wrote: > On Thu, Feb 05, 2026 at 09:59:42PM -0800, Christoph Hellwig wrote: > > On Thu, Feb 05, 2026 at 08:56:24AM -0800, Darrick J. Wong wrote: > > > "In Linux 7.0 we've changed the extended attribute update code to try to > > > take a shortcut for performance reasons. Before walking through the > > > attr intent state machine (slow), the update will check to see if the > > > attr structure is in short format and will stay in that format after the > > > change. If so, then the incore inode can be updated and logged, and the > > > update is complete (fast) in a single transaction. > > > > > > "(Obviously, for complex attr structures or large changes we still walk > > > through the intent machinery.) > > > > > > "However, xfs/018 tests the behavior of the "larp" error injector, which > > > only triggers from inside the attr intent state machine. Therefore, the > > > short format tests don't actually trip the injector. It makes no sense > > > to add a new larp injection callsite for the shortcut because either the > > > single transaction gets written to disk or it doesn't." > > > > Make sense, but from looking at the test I'm still a bit confused > > why it fails (vs just not testing something too useful) > > The golden output no longer matches because the attr update doesn't > return EIO and shut down the filesystem due to the larp injection. Ah, that's the missing bit. Can you add that blurb to the commit message? With that and the above: Reviewed-by: Christoph Hellwig