From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6088447DF89; Tue, 3 Mar 2026 14:54:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772549674; cv=none; b=nBybzX7DdWY+Heg1+0SFtN7T4PjAvmZZeDJULq7k9VRmyDCjc2DR4YUDTk5o7syRMG5jYpsw0z4V4u3Z2thPmK4eQtZ0A+DPZFTj0uPSmZmPZjlKeTX/q+1LDw8+Bcy42wWKuUaTpxjaxmApTHMFvdc1t/93FUTTpm3Zpg5jMw8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772549674; c=relaxed/simple; bh=Moit/K87vMx+jMZRbscMvV2mu0ip1PtbBQxaqyS4EQs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AggJNj1Zt2nna7varF2vkv4nDecqZnrcl5kDO0ghu7j3eB9Sn7MkXLFcPH3haqaEBUD3ahT9v9gIJdgar1P7Ew1uyz6OfvjH8Qk84EpEG81xo/QmnkOEdmokb+HhCXYNPk8jkCeUA6QOXjSjdtHaOd6fgAZ3PWD/URiNgHM7kKk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Vwicla6O; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Vwicla6O" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4jkfdMOGxaOV5m+ZC+AwRoFEfjLylQ+rHaRfwNk7O8U=; b=Vwicla6OpwA/VRQpz/yGJeXdgp NX+CLnYGsqNIehvMHpoIbw9w933GaDmZ7GxahlFSVav/AR8kWx8mf7X6nMAZKWIsgVh9xMcqbuJXC pzvLOLxahgTuZ6rF5lFhOZFERle5fabVWukOlvfohVZ8fPV8toaK/jEzBbaXQUX25GHUBxlhe4yYN isN+Ind667wUw8iyFkXIUN22UEpY7DK5nQs+OKw7A3/V/SoCIMdGCyIfeorwjP6UQ0+0mcCSCFLxV N7vLZc2LLMpBzYwLGPjdmY40IMaKctaTfZUA9bSYJ2Pt8+YhRtDiW7xfzprZZKF0MuqBfqTI1tTSF egMFYnRg==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxR8n-0000000FMSl-0TbL; Tue, 03 Mar 2026 14:54:29 +0000 Date: Tue, 3 Mar 2026 06:54:29 -0800 From: Christoph Hellwig To: "Darrick J. Wong" Cc: zlang@redhat.com, linux-fsdevel@vger.kernel.org, hch@lst.de, gabriel@krisman.be, amir73il@gmail.com, jack@suse.cz, fstests@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/1] generic: test fsnotify filesystem error reporting Message-ID: References: <177249785452.483405.17984642662799629787.stgit@frogsfrogsfrogs> <177249785472.483405.1160086113668716052.stgit@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: fstests@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <177249785472.483405.1160086113668716052.stgit@frogsfrogsfrogs> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright 2021, Collabora Ltd. > + */ Where is this coming from? > +#ifndef __GLIBC__ > +#include > +#endif And what is this for? Looks pretty whacky. > +case "$FSTYP" in > +xfs) > + # added as a part of xfs health monitoring > + _require_xfs_io_command healthmon > + # no out of place writes > + _require_no_xfs_always_cow > + ;; > +ext4) > + # added at the same time as uevents > + modprobe fs-$FSTYP > + test -e /sys/fs/ext4/features/uevents || \ > + _notrun "$FSTYP does not support fsnotify ioerrors" > + ;; > +*) > + _notrun "$FSTYP does not support fsnotify ioerrors" > + ;; > +esac Please abstract this out into a documented helper in common/ > +# > +# The dm-error map added by this test doesn't work on zoned devices because > +# table sizes need to be aligned to the zone size, and even for zoned on > +# conventional this test will get confused because of the internal RT device. > +# > +# That check requires a mounted file system, so do a dummy mount before setting > +# up DM. > +# > +_scratch_mount > +test $FSTYP = xfs && _require_xfs_scratch_non_zoned > +_scratch_unmount Hmm, this is a bit sad. Can we align the map? Or should we carve in and add proper error injection to the block code, which has been somewhere on my todo list forever because dm-error and friends are so painful to setup. Maybe I need to expedite that.