From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A84763B5840; Tue, 3 Mar 2026 16:12:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772554378; cv=none; b=RnuzvSP7sAKDyBuHQGq9lklLwbv98CApg5XofgGv4Foasm71Ttsg4TCphQOO0+N21UFh/BtP2Jeuoq0psFMKn6gMBCHXTLJTZwDEHAicI/FhcU6VWbXX3q3P0fNOZL2DOGT+/BwYn0I5zMyKWtTXSPwrEGvA1MDekgk5yhMjdZA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772554378; c=relaxed/simple; bh=KhB9ELTOeynhh//iB0PKyH93KHWnqbQMCKrNAaPcFFc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u/xDev0YGMN7ROMkCjrc8wnNCRIXH8feplmrSGWE8dCfoKf0MCfVwaEeYYuChPvphhdVefixZ9NhPPYtjx49TxwlbHiedbEYVCoWKwunEpwmooclkMFeBwtFwLm3+ruByJdNmDy3nB1dVmo2tgyJEnlUzoTqhz49UGAQ0YboKIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=RY1qS2zt; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="RY1qS2zt" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xH67VzYcBp5utoAGI6Gx1l1REfSpyFZcE6w/U37h8TA=; b=RY1qS2zttGZw+//8ov57EuqF+F /ZR3FeT9mJXVgtDLYqjCk006VEqjFDp6RBH0EEz5nlcHeaGNiW3gB24wYByij/kXmSaFDD2mPcuYU OsJAH70WxlGSqxNc3tzNHv//4MoaVEQj3Ej4auWz3CK1LvDGoXdueNLbmBs7GdR4kzpwVkWS5GQbs mRPuQU5MDJhp9bCPzFfCd8LVNm7HkwOKaxnyqLqT1yP/W4LpBm0n2RRwHwGKq9i6Prqd+F0+AFstu k5tDoKTt9+0v38BDRjutOxAHEZ5LKgPJdVjOtY89iggdr70YN5zWs23/+7KWs9HLlY5jRnIoen20k rutwgRuA==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxSMh-0000000FXQG-3yLK; Tue, 03 Mar 2026 16:12:55 +0000 Date: Tue, 3 Mar 2026 08:12:55 -0800 From: Christoph Hellwig To: Gabriel Krisman Bertazi Cc: Christoph Hellwig , "Darrick J. Wong" , zlang@redhat.com, linux-fsdevel@vger.kernel.org, hch@lst.de, amir73il@gmail.com, jack@suse.cz, fstests@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/1] generic: test fsnotify filesystem error reporting Message-ID: References: <177249785452.483405.17984642662799629787.stgit@frogsfrogsfrogs> <177249785472.483405.1160086113668716052.stgit@frogsfrogsfrogs> <87ldg83nj7.fsf@mailhost.krisman.be> Precedence: bulk X-Mailing-List: fstests@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ldg83nj7.fsf@mailhost.krisman.be> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Tue, Mar 03, 2026 at 11:06:52AM -0500, Gabriel Krisman Bertazi wrote: > Christoph Hellwig writes: > > >> +// SPDX-License-Identifier: GPL-2.0 > >> +/* > >> + * Copyright 2021, Collabora Ltd. > >> + */ > > > > Where is this coming from? > > This code is heavily based, if not the same, to what I originally wrote > as a kernel tree "samples/fs-monitor.c" when I was employed by > Collabora. I appreciate Darrick keeping the note actually. The note is good. But if we import code from somewhere, we should document where it is coming from, both for attribution and to ease any future resyncs if needed. > >> +#ifndef __GLIBC__ > >> +#include > >> +#endif > > > > And what is this for? Looks pretty whacky. > > Comes from kernel commit 3193e8942fc7 ("samples: fix building fs-monitor > on musl systems") to fix building with musl. We don't need it here. In the place that needs it it really should have a comment explainig the logic behind it.