From: Christoph Hellwig <hch@infradead.org>
To: Jan Prusakowski <jprusakowski@google.com>
Cc: zlang@kernel.org, fstests@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, anand.jain@oracle.com,
wqu@suse.com
Subject: Re: [PATCH] generic/050: handle f2fs as nojournal filesystem
Date: Tue, 14 Apr 2026 00:57:02 -0700 [thread overview]
Message-ID: <ad3zThMKaWZ65XE2@infradead.org> (raw)
In-Reply-To: <20260410131821.991005-1-jprusakowski@google.com>
On Fri, Apr 10, 2026 at 01:18:20PM +0000, Jan Prusakowski wrote:
> F2FS uses a checkpoint mechanism for metadata consistency rather than a
> traditional journal. Roll-forward recovery is only needed if there are
> fsync'd files since the last checkpoint.
>
> In this test case, files are created without fsync, so there is no
> roll-forward data to replay during mount.
>
> Therefore, F2FS does not need to write to the device to recover, and
> successfully mounts on the read-only block device. Thus, it should be
> treated as nojournal in this case.
This looks ok, but I always wonder if we want an opt-in for this
"journaling" behavior and/or define it clear in common/.
prev parent reply other threads:[~2026-04-14 7:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 13:18 [PATCH] generic/050: handle f2fs as nojournal filesystem Jan Prusakowski
2026-04-14 7:57 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad3zThMKaWZ65XE2@infradead.org \
--to=hch@infradead.org \
--cc=anand.jain@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=jprusakowski@google.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=wqu@suse.com \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox