FS/XFS testing framework
 help / color / mirror / Atom feed
From: Zorro Lang <zlang@kernel.org>
To: Colin Walters <walters@verbum.org>
Cc: fstests@vger.kernel.org, Amir Goldstein <amir73il@gmail.com>
Subject: Re: [PATCH] overlay/080: cycle base fs in prepare_midlayer to exercise lazy verity load
Date: Sat, 9 May 2026 17:10:21 +0800	[thread overview]
Message-ID: <af741jzmhTYl0c5Y@zlang-mailbox> (raw)
In-Reply-To: <97140e8a-541c-4e0a-accd-cf58dd1feae6@app.fastmail.com>

On Fri, May 08, 2026 at 04:07:39PM -0400, Colin Walters wrote:
> This reproduces the regression reported at:
> https://github.com/bootc-dev/bootc/issues/2174
> 
> Assisted-by: OpenCode (Claude Sonnet 4.6)
> Signed-off-by: Colin Walters <walters@verbum.org>
> ---
>  tests/overlay/080 | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/tests/overlay/080 b/tests/overlay/080
> index ce5c2375..ede04dab 100755
> --- a/tests/overlay/080
> +++ b/tests/overlay/080
> @@ -21,6 +21,8 @@ _require_scratch_nocheck
>  _require_scratch_overlay_features redirect_dir metacopy
>  _require_scratch_overlay_lowerdata_layers
>  _require_scratch_overlay_verity
> +_fixed_by_kernel_commit 0c8c88b8eb82a2a41bec5f17c076d6312dc40316 \
                           ^^^^^^^^
A short id is enough, e.g. 0c8c88b8eb82 :)

> +    "ovl: fix verity lazy-load guard broken by fsverity_active() semantic change"
>  
>  # remove all files from previous tests
>  _scratch_mkfs
> @@ -222,6 +224,11 @@ prepare_midlayer()
>         echo -n "changed" > $lowerdir/$subdir$wrongverityname
>         _fsv_enable $lowerdir/$subdir$wrongverityname
>         echo "$lowerdata4" > $lowerdir/$subdir$missingverityname
> +
> +       # Cycle the base fs to evict cached inodes, so the overlay mount
> +       # that follows exercises the lazy verity load path from disk.
> +       _overlay_base_unmount "$OVL_BASE_SCRATCH_DEV" "$OVL_BASE_SCRATCH_MNT"
> +       _overlay_base_scratch_mount
>  }
>  
>  test_common()
> -- 
> 2.52.0
> 
> 

      parent reply	other threads:[~2026-05-09  9:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-08 20:07 [PATCH] overlay/080: cycle base fs in prepare_midlayer to exercise lazy verity load Colin Walters
2026-05-08 20:21 ` Amir Goldstein
2026-05-09  9:10 ` Zorro Lang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af741jzmhTYl0c5Y@zlang-mailbox \
    --to=zlang@kernel.org \
    --cc=amir73il@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=walters@verbum.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox