Re: [PATCH v1 2/2] f2fs/021: Fix mount syntax for disabling jquota

[Zorro Lang <zlang@kernel.org>]

On Wed, May 13, 2026 at 03:20:09AM +0000, Joanne Chang wrote:
> F2FS has removed the trailing "=" in the mount options for disabling
> user journaled quotas. Update f2fs/021 to try the new syntax first and
> fall back to the legacy syntax if the initial mount attempt fails.
> 
> Signed-off-by: Joanne Chang <joannechien@google.com>
> ---
>  tests/f2fs/021 | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/f2fs/021 b/tests/f2fs/021
> index 0cacb138..70b10fa8 100755
> --- a/tests/f2fs/021
> +++ b/tests/f2fs/021
> @@ -21,7 +21,9 @@ quotacheck -uc $SCRATCH_MNT
>  _scratch_unmount
>  
>  _scratch_mount "-o usrjquota=aquota.user,jqfmt=vfsold"
> -_scratch_mount "-o remount,usrjquota=,jqfmt=vfsold"
> +if ! _try_scratch_mount "-o remount,usrjquota,jqfmt=vfsold" >> $seqres.full 2>&1; then
> +	_scratch_mount "-o remount,usrjquota=,jqfmt=vfsold"
> +fi

I’ve explored several ways to solve this more elegantly. Otherwise, every
single F2FS quota test case might run into this exact same issue. but I can't
find any good idea currently. For example, if we do something in _try_scratch_mount:

	local mount_opts=`_scratch_mount_options $*`
	if [ "$FSTYP" == "f2fs" ]; then
		mount_opts=`_f2fs_quota_options "$mount_opts"`
	fi

However, F2FS seems to only distinguish the '=' usage through a trial mount,
so doing it inside _try_scratch_mount is definitely not a good idea. Is there
a way to probe this without mounting? Like relying on some --help output or
something similar? Any good ideas from others?

Thanks,
Zorro

>  _scratch_unmount
>  
>  echo "Silence is golden"
> -- 
> 2.54.0.563.g4f69b47b94-goog
>